emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Christopher M. Miles" <numbchild@gmail.com>
To: Michael Eliachevitch <m.eliachevitch@posteo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-contacts.el use lexical-let  not defined in cl-lib
Date: Mon, 21 Mar 2022 19:36:04 +0800	[thread overview]
Message-ID: <m2wngn8rj9.fsf@numbchild@gmail.com> (raw)
In-Reply-To: <87czul1e8p.fsf@posteo.de>

[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]


Michael Eliachevitch <m.eliachevitch@posteo.de> writes:

> [[PGP Signed Part:Undecided]]
> Dear all,
>
> I'm not sure if this is the correct mailinglist for org-contrib bugs. I found that org-contacts.el uses `lexical-let*` which is defined in `cl`, but it only requires `cl-lib` where it is not defined.
>
> I found this because I use `org-contacts-message-complete-function` to autocomplete contacts in mu4e
> and recently it started giving me errors, see this stacktrace:
>
>    Debugger entered--Lisp error: (void-function start)
>      start(121)
>      org-contacts-message-complete-function()
>      completion--capf-wrapper(org-contacts-message-complete-function       all)
>      completion-at-point()
>      message-tab()
>      funcall-interactively(message-tab)
>      command-execute(message-tab)
>
> However, when I went to the source file and evaluated it (or used the debugger), everything worked
> fine. So it seems this error was just occurring when running over the compiled file (I compile to
> elc via the nativ-comp branch and with straight).
>
> I then did a search for the query and found a stackexchange post
> (https://emacs.stackexchange.com/a/18727) which gave me the idea for the cause. Adding `(require cl)
> to the file and recompiling it fixed the error.
>
> My org version is release_9.4.5-321-ge641d3. However, I see that on the master branch still uses
> lexical-let*.
>
> Is this a bug or some error in my configuration? Should I send an email elsewhere or submit a
> bug-report? Because (require 'cl) is deprecated, test solution would be to replace the lexical-let*
> with something else like a normal let*, but I'm not confident enough in my lisp to do this by
> myself.
>
> Best regards,
> Michael Eliachevitch

Sorry for late response, I missed this thread. I checked source code for now, It should have been
fixed now. Can you check it out? Thanks for bug reporting.

-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      parent reply	other threads:[~2022-03-21 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:27 Michael Eliachevitch
2021-04-24  5:05 ` Kyle Meyer
2022-03-21 11:36 ` Christopher M. Miles [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wngn8rj9.fsf@numbchild@gmail.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=m.eliachevitch@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).