From: Rainer M Krug <Rainer@krugs.de>
To: Charles Berry <ccberry@ucsd.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] -for review- Tangling with variable transfer of variables
Date: Fri, 20 Jun 2014 15:15:31 +0200 [thread overview]
Message-ID: <m2vbrv7mdo.fsf@krugs.de> (raw)
In-Reply-To: <loom.20140620T002034-706@post.gmane.org> (Charles Berry's message of "Thu, 19 Jun 2014 23:23:56 +0000 (UTC)")
[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]
Charles Berry <ccberry@ucsd.edu> writes:
> Aaron Ecay <aaronecay <at> gmail.com> writes:
>
>>
>> Hi Rainer,
>>
>> I have not tested the patch (I rarely use :var), but here are some
>> comments from reading the patch.
>>
> [snip]
>>
>> > (header (if (or (eq (nth 1 value) 'hline) colnames-p)
>> > "TRUE" "FALSE"))
>> > (row-names (if rownames-p "1" "NULL")))
>> > (if (= max min)
>> > - (format "%s <- read.table(\"%s\",
>> > + (format "%s <- read.table(textConnection('%s'),
>>
>> This will fail if ‘file’ contains an apostrophe character. I guess you
>> need to escape apostrophes in ‘file’.
>>
>
> There are a bunch of issues with the textConnection - the point Aaron
> makes, the nasty name (try showConnections() to see), and close()-ing it.
>
> I think you need something more like this:
>
> ====
> (header (if (or (eq (nth 1 value) 'hline) colnames-p)
> "TRUE" "FALSE"))
> (row-names (if rownames-p "1" "NULL")))
> (if (= max min)
> (format "
> %s <-
> local({con.object <-
> %S
> con <- textConnection(con.object)
> res <- read.table(con,
> header=%s,
> row.names=%s,
> sep=\"\\t\",
> as.is=TRUE)
> close(con)
> res})"
> name file header row-names)
>
> ====
>
> Notes: %S handles Aaron's quoting issue.
> local() keeps unwanted objects out of user's way.
> This worked on a couple of simple tests
I agree completely here - thanks for the %S (didn't know about it - now
I do) and haven't thought about the local() - I think it is a very good
idea to use it in the context of the variable transfer.
>
> If you have `:session :results output' headers your session
> transcript will have `file' dumped into it, which might be an annoyance.
Not only annoyance - can cause overwriting of the data. Will look into
this.
Thanks a lot,
Rainer
>
> HTH,
>
> Chuck
>
>
>
>
--
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)
Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa
Tel : +33 - (0)9 53 10 27 44
Cell: +33 - (0)6 85 62 59 98
Fax : +33 - (0)9 58 10 27 44
Fax (D): +49 - (0)3 21 21 25 22 44
email: Rainer@krugs.de
Skype: RMkrug
PGP: 0x0F52F982
[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]
next prev parent reply other threads:[~2014-06-20 13:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 20:19 [PATCH] -for review- Tangling with variable transfer of variables Rainer M Krug
2014-06-19 21:09 ` Aaron Ecay
2014-06-19 23:23 ` Charles Berry
2014-06-20 13:15 ` Rainer M Krug [this message]
2014-06-20 20:34 ` Rainer M Krug
2014-06-21 19:44 ` Charles C. Berry
2014-06-22 3:39 ` Aaron Ecay
2014-06-23 10:46 ` Rainer M Krug
2014-06-23 8:57 ` Rainer M Krug
2014-06-23 9:14 ` Rainer M Krug
2014-06-23 17:56 ` Charles C. Berry
2014-06-24 12:08 ` Rainer M Krug
2014-06-23 10:45 ` Rainer M Krug
2014-06-23 18:25 ` Charles C. Berry
2014-06-24 12:28 ` Rainer M Krug
2014-06-20 13:07 ` Rainer M Krug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vbrv7mdo.fsf@krugs.de \
--to=rainer@krugs.de \
--cc=ccberry@ucsd.edu \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).