From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Hodique Subject: Re: [PATCH] Fix inconsistency in drawer handling Date: Sun, 16 Sep 2012 19:03:51 +0200 Message-ID: References: <1347710412-23188-1-git-send-email-yann.hodique@gmail.com> <87boh7layo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDIY1-0002lF-Hv for emacs-orgmode@gnu.org; Sun, 16 Sep 2012 13:22:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDIY0-00035t-EG for emacs-orgmode@gnu.org; Sun, 16 Sep 2012 13:22:21 -0400 Received: from plane.gmane.org ([80.91.229.3]:43715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDIY0-00035p-7j for emacs-orgmode@gnu.org; Sun, 16 Sep 2012 13:22:20 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TDIY0-0007fF-PC for emacs-orgmode@gnu.org; Sun, 16 Sep 2012 19:22:20 +0200 Received: from home.hodique.info ([78.213.112.104]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Sep 2012 19:22:20 +0200 Received: from yann.hodique by home.hodique.info with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Sep 2012 19:22:20 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org >>>>> "Nicolas" == Nicolas Goaziou writes: > This patch is good, but I'd rather hard-code the regexp within > org-element: I'm slowly trying to make this library as low-level as > possible. Do you mind changing it? Hi, thanks for the quick review. Of course I don't mind, but I'm just curious to understand the purpose, as duplicating constants seems to make room for future mistakes (even though in this case I guess we're stuck with that regexp forever :)). Do you mean you'd like to get rid of (require 'org) in org-element.el at some point ? What about (eval-when-compile '(require 'org)) then ? Or some (require 'org-const) ? Thanks, Yann. -- How often it is that the angry man rages denial of what his inner self is telling him. -- "The Collected Sayings of Muad'Dib" by the Princess Irulan