emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Yann Hodique <yann.hodique@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix inconsistency in drawer handling
Date: Sun, 16 Sep 2012 19:03:51 +0200	[thread overview]
Message-ID: <m2txuxnbm0.fsf@jarvis.hodique.info> (raw)
In-Reply-To: 87boh7layo.fsf@gmail.com

>>>>> "Nicolas" == Nicolas Goaziou <n.goaziou@gmail.com> writes:

> This patch is good, but I'd rather hard-code the regexp within
> org-element: I'm slowly trying to make this library as low-level as
> possible. Do you mind changing it?

Hi,

thanks for the quick review. Of course I don't mind, but I'm just
curious to understand the purpose, as duplicating constants seems to
make room for future mistakes (even though in this case I guess we're
stuck with that regexp forever :)).

Do you mean you'd like to get rid of (require 'org) in org-element.el at
some point ? What about (eval-when-compile '(require 'org)) then ? Or
some (require 'org-const) ?

Thanks,

Yann.

-- 
How often it is that the angry man rages denial of what his inner self is 
telling him.

  -- "The Collected Sayings of Muad'Dib" by the Princess Irulan

next prev parent reply	other threads:[~2012-09-16 17:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15 12:00 [PATCH] Fix inconsistency in drawer handling Yann Hodique
2012-09-15 12:00 ` Yann Hodique
2012-09-15 12:36 ` Nicolas Goaziou
2012-09-16 17:03   ` Yann Hodique [this message]
2012-09-19 14:02     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2txuxnbm0.fsf@jarvis.hodique.info \
    --to=yann.hodique@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).