From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thomas S. Dye" Subject: Re: a patch to ob-lisp.el Date: Wed, 30 Mar 2016 06:52:31 -1000 Message-ID: References: <874mbtz0pb.fsf@gmail.com> <87oa9zxnbp.fsf@pierrot.dokosmarshall.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alJMn-0007H5-T6 for emacs-orgmode@gnu.org; Wed, 30 Mar 2016 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alJMj-0000Qp-Ot for emacs-orgmode@gnu.org; Wed, 30 Mar 2016 12:53:13 -0400 Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:35840) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1alJMj-0000QS-HE for emacs-orgmode@gnu.org; Wed, 30 Mar 2016 12:53:09 -0400 In-reply-to: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "numbchild@gmail.com" Cc: Nick Dokos , Org-mode Aloha stardiviner, For instructions about the FSF papers, see http://orgmode.org/worg/org-contribute.html. All the best, Tom numbchild@gmail.com writes: > I updated all comments which you point out. > I wandering how to sign the FSF papers? Sorry about this, this is my first time > to contribute code in open source. > > > > [stardiviner] GPG key ID: 47C32433 > IRC(freeenode): stardiviner Twitter: @numbchild > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 > Blog: http://stardiviner.github.io/ > > On Mon, Mar 28, 2016 at 12:01 PM, Nick Dokos wrote: > > stardiviner writes: > > > I hope to merge this patch to Org-mode `ob-lisp.el`. > > > > I have only looked at the surface of it, but I see some issues. > > > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > > --- > > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. > > Why did you leave out the previous copyright statement? > Where did 2020 come from? > > > < ;; Authors: stardiviner > > < ;; Maintainer: stardiviner > > < ;; Keywords: org babel lisp sly slime > > < ;; URL: https://github.com/stardiviner/ob-lisp > > < ;; Created: 1th March 2016 > > < ;; Version: 0.0.1 > > < ;; Package-Requires: ((org "8")) > > --- > >> ;; Authors: Joel Boehland > >> ;; Eric Schulte > >> ;; David T. O'Toole > >> ;; Keywords: literate programming, reproducible research > >> ;; Homepage: http://orgmode.org > > Why did you erase the previous authors? > > Are you volunteering to be the maintainer of ob-lisp.el or are you > planning to keep your own repo and submit patches? Have you signed FSF > papers? > > > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME > > < ;; See: > > < ;; - https://github.com/capitaomorte/sly > > < ;; - http://common-lisp.net/project/slime/ > > --- > >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.) > >> ;; See http://common-lisp.net/project/slime/ > > Does it really require both? If so, I suggest you rework it so > either can be used, but only one is required. If not, I suggest > you fix the comment. > > -- > Nick -- Thomas S. Dye http://www.tsdye.com