From: Stig Brautaset <stig@brautaset.org>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: [PATCH] Use cl-lib rather than cl variants in org-drill
Date: Fri, 14 Jul 2017 20:57:39 +0100 [thread overview]
Message-ID: <m2r2xi7pvw.fsf@Margil.home> (raw)
[-- Attachment #1: Type: text/plain, Size: 102 bytes --]
org-drill requires only cl-lib rather than cl, so should use cl-gensym
rather than gensym I believe.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-org-drill.el-use-cl-gensym-rather-than-gensym.patch --]
[-- Type: text/x-patch, Size: 796 bytes --]
From 1eef99d550e467bf4a3eaf6bdbe4d3a482f6c187 Mon Sep 17 00:00:00 2001
From: Stig Brautaset <stig@brautaset.org>
Date: Fri, 14 Jul 2017 20:45:37 +0100
Subject: [PATCH 2/3] org-drill.el: use cl-gensym rather than gensym
cl-lib is already required by this file, but cl is not.
---
contrib/lisp/org-drill.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
index fb578ab86..7c4a29930 100644
--- a/contrib/lisp/org-drill.el
+++ b/contrib/lisp/org-drill.el
@@ -622,7 +622,7 @@ regardless of whether the test was successful.")
(defmacro pop-random (place)
- (let ((idx (gensym)))
+ (let ((idx (cl-gensym)))
`(if (null ,place)
nil
(let ((,idx (random* (length ,place))))
--
2.11.0 (Apple Git-81)
[-- Attachment #3: Type: text/plain, Size: 54 bytes --]
Stig
--
; GNU Emacs 26.0.50, Org mode version 9.0.9
next reply other threads:[~2017-07-14 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 19:57 Stig Brautaset [this message]
2017-07-23 9:09 ` [PATCH] Use cl-lib rather than cl variants in org-drill Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r2xi7pvw.fsf@Margil.home \
--to=stig@brautaset.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).