From: Rudolf Schlatte <firstname.lastname@example.org> To: email@example.com Subject: bug#48149: 27.2; Wrong underline width when the line char has a width of 2 Date: Sun, 02 May 2021 10:36:14 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Eli Zaretskii <firstname.lastname@example.org> writes: >> Date: Sun, 02 May 2021 10:12:43 +0900 >> From: Shingo Tanaka <email@example.com> >> >> When exporting org-mode document to plain text (either ascii/unicode/utf-8) >> with `org-export-dispatch', Emacs inserts lines under headlines, inline >> tasks, table rows and titles of the document, TOC, list of listings, list of >> tables and footnotes. The problem is it inserts too long (double width) line >> when the line character has a width of 2. >> >> Those lines are made of 3 types of characters below (in ox-ascii.el): >> 1) org-ascii-underline >> 2) (if (eq (plist-get info :ascii-charset) 'utf-8) ?─ ?_) >> 3) (if utf8p ?━ ?_) >> >> In case of 1), it correctly takes account of the case in which the character >> has a width of 2 in `org-ascii--build-title', by dividing the line width by >> `(char-width under-char)' (line 700-701), maybe because the character is user >> configurable and its width in unknown. However, in case of 2) and >> 3), maybe because the characters is embedded in the code, it looks like only >> considering the character always has a width of 1. But the reality is >> character ?─ or ?━ can have a width of 2 in the screen displayed with some >> fonts (ex. "Noto Sans Mono CJK JP"), and in that case the line width gets >> doubled of the expected width. >> >> Attached one is a potential patch. The basic concepts are: >> >> a) Do the same in case of 2) and 3) as in case of 1) >> (dividing the line width by `(char-width under-char)', >> assuming `char-width-table' is correctly set) >> >> b) Prefer the longer line width if the width is odd, even in case of 1) >> (adding `(1- (char-width under-char))' to dividend, >> just because it should be more beautiful ;-) ) > > You reported a similar bug already, and I replied there that TRT in > these cases is to use window-text-pixel-size, which will automatically > account for the actual width on display of any characters and any > fonts specified for displaying them. char-width is an approximation, > and is accurate only on TTY frames. Isn't the primary result of org-export a plain (UTF-8) text file, instead of an emacs buffer to be displayed in a GUI or TTY frame? If so, maybe the criterion for correctness should be that "cat filename.txt" looks as expected in a terminal, even if opening that file in Emacs shows lines of different lengths due to variable-pitch faces etc.
next prev parent reply other threads:[~2021-05-02 13:09 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> 2021-05-02 7:17 ` Eli Zaretskii [not found] ` <email@example.com> 2021-05-02 8:36 ` Rudolf Schlatte [this message] 2021-05-02 9:16 ` Eli Zaretskii 2021-05-02 16:08 ` Nicolas Goaziou 2021-05-02 16:23 ` Eli Zaretskii 2021-05-09 13:57 ` Shingo Tanaka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: bug#48149: 27.2; Wrong underline width when the line char has a width of 2' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).