emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Rudolf Adamkovič" <salutis@me.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: [BUG] Hard-coded begin/end in org-insert-structure-template [9.5.2 (release_9.5.2-24-g668205 @ /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/)]
Date: Tue, 22 Mar 2022 21:44:18 +0100	[thread overview]
Message-ID: <m2pmmdu38d.fsf@me.com> (raw)
In-Reply-To: <871qywerpi.fsf@localhost>

Ihor Radchenko <yantar92@gmail.com> writes:

> We can auto-magically determine whether to use BEGIN_ or begin_
> depending on the case in template type. Tentative patch attached.


> +with \"#+begin_\" and \"#+end_\" added automatically.  If the block
> +type is written using upper case letter, \"#+BEGIN_\" and \"#+END_\"
> +are added instead.

FYI: A typo in "letter" (expected "letters")

(We could also simplify to: "if the block type consists of just
uppercase letter".)

> +  (let* ((case-fold-search t) ; Make sure that matches are case-insnsitive.
> +         (region? (use-region-p))

FYI: A typo in "case-insnsitive" (expected "case-insensitive")

Looking forward to seeing this merged!

"I love deadlines.  I love the whooshing noise they make as they go by."
-- Douglas Adams, The Salmon of Doubt, 2002

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava

  reply	other threads:[~2022-03-22 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-20 11:43 [BUG] Hard-coded begin/end in org-insert-structure-template [9.5.2 (release_9.5.2-24-g668205 @ /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/)] Rudolf Adamkovič
2022-03-20 12:25 ` [PATCH] " Ihor Radchenko
2022-03-22 20:44   ` Rudolf Adamkovič [this message]
2022-03-23 11:59     ` Ihor Radchenko
2022-03-25  6:34       ` Rudolf Adamkovič
2022-06-18  6:28         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2pmmdu38d.fsf@me.com \
    --to=salutis@me.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).