From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eLgjM0tSC2OqfwAAbAwnHQ (envelope-from ) for ; Sun, 28 Aug 2022 13:32:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yO78MktSC2MEAQEAauVa8A (envelope-from ) for ; Sun, 28 Aug 2022 13:32:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73BF1219A9 for ; Sun, 28 Aug 2022 13:32:27 +0200 (CEST) Received: from localhost ([::1]:47600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSGWg-0006yn-8E for larch@yhetil.org; Sun, 28 Aug 2022 07:32:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSGWG-0006yX-7e for Emacs-orgmode@gnu.org; Sun, 28 Aug 2022 07:32:00 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:34542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oSGWE-0002MM-Dk for Emacs-orgmode@gnu.org; Sun, 28 Aug 2022 07:31:59 -0400 Received: by mail-ed1-x52d.google.com with SMTP id z2so7109975edc.1 for ; Sun, 28 Aug 2022 04:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:from:to:cc; bh=GD+JuIGzTsMK7howaSt8E/59qkrwrPBLh0uUj4qr0l8=; b=VeD8loBL38b3phl5IGoQajchjsfVtyr1JxIu8kLsr0BLALExeCZhfxaAcTjRRfMbG+ T3U8y0DFlcZx0b1NjEuo9NZGhiZqJb9wefAJaD/jf6YcuCpZLjhjY6GIrMw9J0omuGiz YM4qO8/UlEyMcLJObIE1dbDgNuIvoWhobQsf+YhbBUZvCRGDYUxGFIT7nkJrdC87qx+h onLwqixeNh5N7nl8EbLR5WiHVG3KbPonbv+sq0WNaOF0DhpfaAY+qpW+Pi/ZyoCfq8+S jabjRLSu6AAwBIYErCIlXejzL3UTxipBxBo0z7zRtuGePEUhqCf1JsivFMzm2eJ2TSuN NqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:user-agent:references:date :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GD+JuIGzTsMK7howaSt8E/59qkrwrPBLh0uUj4qr0l8=; b=rYMvilLsJE80n0e0ZiwG7SnaEeo1Rr3iXy/SLq02vzSdg3Xo/gM0PV9zaSAH7T6jL6 gRyoWS2EEKWxZXdg9h/THbEZCDI0Ch95BQg7ZmWONR1oMuyVxoenY8+eAFermwK6d93u mGOn99WzFH/SIvnlPvKizai6Nc2dBnGeWsyiYi8QYzXqZbo4bqGn8WiXc0j+y5Urpw49 54oyKng79B5edXDyyJh3CEBN0hSavlwhuCN0/9iwNe7G8cVfkZe203DRVXpemdiOgSXJ w0MnbVsXvvKx8QZgWptl4RLPZi4gbAvC7XBETP1vATApkBv16PPQkHJkrR66MSmXqmgI BLcg== X-Gm-Message-State: ACgBeo3mgk6b7ryn2eFZZhCq12aWLvwEzbJJ0zg53D1BFAdxMN7wtN6e rd/mH0TChCkuhXRirMGeffM= X-Google-Smtp-Source: AA6agR6FyIY3lByEjQ6Hu1B93xRYiXPS+u0lp20kiWQFvsLWxNjCMSqFWc5DnX7vhvPvPJoBBdGVwQ== X-Received: by 2002:a05:6402:1446:b0:448:5081:efc7 with SMTP id d6-20020a056402144600b004485081efc7mr2410034edx.428.1661686316870; Sun, 28 Aug 2022 04:31:56 -0700 (PDT) Received: from localhost (h59074.upc-h.chello.nl. [62.194.59.74]) by smtp.gmail.com with ESMTPSA id l17-20020a1709060cd100b0073d81b0882asm3084170ejh.7.2022.08.28.04.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Aug 2022 04:31:56 -0700 (PDT) From: Duy Nguyen To: Duy Nguyen Cc: Emacs-orgmode@gnu.org Subject: Re: [PATCH v3] Show org file title in org-clock clocktable Date: Sun, 28 Aug 2022 13:30:56 +0200 References: <87edxk7etq.fsf@localhost> <87tu6g5qbp.fsf@localhost> <87fshv1aet.fsf@localhost> <87k073o2zs.fsf@localhost> User-agent: mu4e 1.6.11; emacs 29.0.50 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=ddnguyen2101@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661686347; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GD+JuIGzTsMK7howaSt8E/59qkrwrPBLh0uUj4qr0l8=; b=V0yDHPL6J84HxjJjO/DW1FLeRmnIOc1v4LBTfqfybnIOXXzmY0Z81z2P0cvTnDDBBN2QKK gft+Ef83JAMfN54IhgmnPYljnq68+K8zGPB/c6/wuDeyqG2f+ozXzU6N7MEIkjc3S8VLx8 AUtFvSUDKNrJ0U7w+Y3PKp8mI17JPzNQmiNpch6LPWdNre7LJXgq6ltLlWMOlcFeckrW1i qB7YMLfCEluZf6YN9HFY6bsM9GwtekvVdVdd9a97fvzgOEVv5wTPA1LPs1j5dOE7FJ6Jg1 VvAmGegTimqgE0+ESv3K56v2jSSCOF5oxAoZ5i1otGzIcpWYMsw1wczl1DT7ZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661686347; a=rsa-sha256; cv=none; b=sJ0y8yNcb1266rzZYfFxcgIMqfwK/cG9M28pJM1rBlGWVJwERAn0/hs3QP6glrZS+2REpL xBShJQo34FM29/wxEy/W0gH5mTFWML6/74RECEZ5w1/dq8fCQvtXStBj4S/0qdV4xLcRwK 2fCPT3WISVLI88xLbODfh0kdVcE3IB5eaHPPmBXcWcyZsmnprIRCRzyuFdqtih+H+bi+S4 1EXKU8YX0PkCvvY69eDOgu/ZfdL7MkYk+ERgv0vq+szoFgmNyci4NydsNlBO/hXzUXLSvB rlwEvw99ArmHw2fcIHjamMCUMPc6+ueFzbWnEUNU+udzEeAn62xrQvMGXjHrrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VeD8loBL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.09 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VeD8loBL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 73BF1219A9 X-Spam-Score: -3.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: sllfd+ToTanN --=-=-= Content-Type: text/plain Content-Disposition: inline That is fine, thanks. Regards, Duy Duy Nguyen writes: > Duy Nguyen writes: > >> Duy Nguyen writes: >> >>>> Thanks for the update! >>>> Applied onto main via 2cc2d8f1f with amendments. >>>> I fixed on double space " " between sentences, removed autoload cookie >>>> (that function is not used outside org-clock), and altered the docstring >>>> making the first line a single sentence and clarifying about the return >>>> value a bit. >>>> >>> >>> Thank you so much for your guidance throughout this patch, hopefully I >>> will be able to contribute to better patches myself in the future! >>> >>> Duy >> >> Thanks man! >> >> >> Regards, >> >> >> --- >> >> *Duy* > > That works! > > > Regards, > > > --- > > Duy --=-=-=--