From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thomas S. Dye" <tsd@tsdye.com>
Subject: Re: patch for custom colored links in org-mode
Date: Tue, 28 Jun 2016 08:34:06 -1000
Message-ID: <m2lh1p2me9.fsf@tsdye.com>
References: <m2d1n43we8.fsf@Johns-MacBook-Air.local>
	<87twgdxtfm.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tsd@tsdye.com>) id 1bHxq4-0001Ss-Jg
	for emacs-orgmode@gnu.org; Tue, 28 Jun 2016 14:34:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tsd@tsdye.com>) id 1bHxq0-0004sV-AO
	for emacs-orgmode@gnu.org; Tue, 28 Jun 2016 14:34:23 -0400
Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:59656)
	by eggs.gnu.org with smtp (Exim 4.71) (envelope-from <tsd@tsdye.com>)
	id 1bHxq0-0004s1-2T
	for emacs-orgmode@gnu.org; Tue, 28 Jun 2016 14:34:20 -0400
In-reply-to: <87twgdxtfm.fsf@saiph.selenimh>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org mode <emacs-orgmode@gnu.org>, John Kitchin <jkitchin@andrew.cmu.edu>


Nicolas Goaziou writes:

> Hello,
>
> John Kitchin <jkitchin@andrew.cmu.edu> writes:
>
>> I tried this aproach to enable custom colored links in org-mode if an
>> org-link-type face is defined. If no face is applied, then it just gets
>> the default org-link face
>>
>> For example this will make all doi links red.
>>
>> (defface org-link-doi
>>   `((t (:inherit org-link
>>                  :foreground "red")))
>>   "Color for doi links.")
>>
>> It seems to work pretty well for me. What do you think about making this
>> a feature in org-mode?
>
> This sounds like a good idea. Thank you for submitting it.
>
> However, I'm not convinced by the UI, i.e., creating a face specifically
> named to trigger the feature. As a user, it doesn't seem very natural to
> me.
>
> At first I thought it was better to extend `org-add-link-type' with
> a FACE definition, but we wouldn't have caught default link types.
>
> So, maybe it is more reasonable to create a new variable, e.g.,
> `org-link-display-parameters', which would hold an alist between link
> types and property lists (or something else), e.g.,
>
>   ("doi" :face my-special-face :display full)
>   ("special" :display path)
>
> Note that :display is a way to include your other idea about link
> visibility. Default value for :face and :display would be, respectively,
> `org-link' and `description'.
>
> Of course, we can also create two variables, one for the face, the other
> for the visibility.

Great idea.  Thanks to John and Nicolas for bringing it up.

A single variable seems sufficient to me and easier to configure.

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com