From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AK+kBorVW2PPTAAAbAwnHQ (envelope-from ) for ; Fri, 28 Oct 2022 15:13:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qPZVBorVW2MKRgAAauVa8A (envelope-from ) for ; Fri, 28 Oct 2022 15:13:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D6CF145EF for ; Fri, 28 Oct 2022 15:13:45 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooPA6-0002sU-B5; Fri, 28 Oct 2022 09:12:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooPA1-0002m0-Tz for emacs-orgmode@gnu.org; Fri, 28 Oct 2022 09:12:33 -0400 Received: from mr85p00im-ztdg06021201.me.com ([17.58.23.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooPA0-0003ke-FJ for emacs-orgmode@gnu.org; Fri, 28 Oct 2022 09:12:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1666962750; bh=8DSXm5PVnH8XY6VgYdbjE7yz2rCbPkvjqmWYQUqGk2A=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gTcujykUI10B0f6yBpoKZBDfl+tQwOlgw2SVtwUoAYrTbtmcm60q8J0eWphWR+vBo qDyzQhooqMZElKKYB61BSYTz6AVs9dvvRSaNzpeAP6xYN+nDVBDlLJbLamYn/h8C18 BP5P2wc26RtIjhb8mvjSImLuh0+ciqv58Qsm/g84M3iVPsKcOrYpwQKD32Dqc/dQXl Jpv8+NW6gTKErJexzepcZogeiAn946+io2MOkSGPcD9QhWx2ZoEsdLsvuKRsrbAyNn u3YfT0kr/qxk4dKmS+zWoyg2TzwzhSn6R/skjoeqztYWpQ7ODuRRUQlZB/4FAm+cjz YH7oOC4JmbD8A== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06021201.me.com (Postfix) with ESMTPSA id 87DB9320305; Fri, 28 Oct 2022 13:12:29 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: Ihor Radchenko , emacs-orgmode@gnu.org Subject: Re: Org 9.6-pre and Bash sessions In-Reply-To: <87wn8lorc1.fsf@localhost> References: <87edvbysqc.fsf@localhost> <87r0z6j1b1.fsf@localhost> <87pmel68y6.fsf@localhost> <87o7u432tl.fsf@localhost> <87a65o15ut.fsf@localhost> <87fsffqi49.fsf@localhost> <87wn8lorc1.fsf@localhost> Date: Fri, 28 Oct 2022 15:12:24 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: DSduVeYn6igssKq-lhMYFPBxALpDC_pS X-Proofpoint-GUID: DSduVeYn6igssKq-lhMYFPBxALpDC_pS X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.816,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-18=5F01:2022-01-14=5F01,2022-01-18=5F01,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=662 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210280082 Received-SPF: pass client-ip=17.58.23.189; envelope-from=salutis@me.com; helo=mr85p00im-ztdg06021201.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666962825; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=8DSXm5PVnH8XY6VgYdbjE7yz2rCbPkvjqmWYQUqGk2A=; b=uBGlyncp/YNaEKR/BzTAxIyBfFtDPz4L7uKKO2wYqL4MBOy1rDbeRWDna4ciOfJCQDp41J sTdJ6YtORYQ3XiCYWvsN97mtRkFWka91d/xFFBH8l1d7Be0CODFKfVlm2mGWWCWXpURGb4 Sqb7mw+FZ2vgDLYM1Fy8z6qg6exTFaRU3hkRrXpRIUuFrRE9lXYdO88w08mjzT/trdcoCS hzKhxHqJO8GwIxWWdHes2UQiJ3fXmZELnv8ngEAxDE8ODk5h1wGWwm2EXoFNuY1Z715yKF 5Vq2CW6qSvBga4FE4k3p5tlU7EQ8GP43B/INx59RzaZ6wHcgykheCHH6aE8nTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666962825; a=rsa-sha256; cv=none; b=hRfZAa7l82CJJGzxuJm1tdIB3Vj7BO5wynxoJIBWjMUsBkiHMi6h+iA2uTCMg1ZL4Ic8Kg UqH+cb9PfLVHYkjbhQxptD2bdAnnPjBFEsXCpwqyDAllXrLgDbunxBGwF61VMDucDDISnN Z4V7ETFvEl6MJOnNFXCeksQo8ofy93+lGsvnyCwNuf7VhtC2CItf6ZPBcgx/qG8/u1VLFp d/mVGopOrOlgDI5n84aQR3HNtXCBQhBhYmyPjtbuL79emlV1lp05LwcrFa8XRVMSi30pZb tYNg5kgszSuZbzY7mjPNaAoEuSgUDDDeBTyGCwPb8Oph6qDmByDz6CIEvX7BRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=gTcujykU; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.52 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=gTcujykU; dmarc=pass (policy=quarantine) header.from=me.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D6CF145EF X-Spam-Score: -5.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: zMcolvJdE7MH Ihor Radchenko writes: >> 1. ob-shell/error-output-after-success >> >> We seem to trash error output, such as warnings, on success. I >> think we should not do this. Now, on the execution of "echo X >> &>2", Org says "Code block produced no output." But that does >> hold true. The block did produce output, just on the other output >> stream, namely error output. > Trashing error output is expected by default. [...] I suggest you to > read through [...] ob-shell follows the spec here. I get that ':results output' makes Org capture standard output, but not error output, for its #+RESULTS. However, if you look at the test in question, you will see that it expects error output in the *Org-Babel Error Output* buffer, not in the #+RESULTS. We should not trash error output; it belongs in the *Org-Babel Error Output* buffer. >> 2. ob-shell/error-output-after-failure > Now done in [...] Thanks! This works *correctly* now. >> 3. ob-shell/exit-codes >> >> Should we add a newline after the exit code message? > Done. I updated the tests and now every string needs a final newline, which does not seem correct. If we let the tests guide our design, all becomes clear. Buffers that use the 'compilation-mode' never append data on re-execution. Instead, they clear the buffer. Thus, we should 1. undo this change and instead 2. call 'org-babel-eval-wipe-error-buffer' before execution. Rudy --=20 "The whole science is nothing more than a refinement of everyday thinking." -- Albert Einstein, 1879-1955 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia