From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Schmitt Subject: Re: [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes Date: Wed, 05 Feb 2014 13:40:55 +0100 Message-ID: References: <87txf1xrnr.fsf@gmx.us> <8761ph8e38.fsf@gmx.us> <87ppnpuuuf.fsf@gmail.com> <871u058502.fsf@gmx.us> <878uudukcs.fsf@gmail.com> <87bnz0jhv3.fsf@gmx.us> <877g9nvh6j.fsf@gmail.com> <874n4e1hxi.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB1mw-0007GQ-S5 for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 07:41:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB1mp-00057q-Hh for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 07:41:10 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:61120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB1mp-00057b-BH for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 07:41:03 -0500 In-Reply-To: <874n4e1hxi.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 05 Feb 2014 02:12:25 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org, n.goaziou@gmail.com Hello Rasmus, I applied the first patch, with the following small changes. This part would not apply: --8<---------------cut here---------------start------------->8--- @@ -252,7 +258,7 @@ This option can also be set with the OPTIONS keyword, e.g.: :group 'org-export-koma-letter) (defcustom org-koma-letter-use-backaddress nil - "Non-nil prints return address in small line above to address. + "Non-nil prints return address in line above to address. This option can also be set with the OPTIONS keyword, e.g.: \"backaddress:t\"." :group 'org-export-koma-letter --8<---------------cut here---------------end--------------->8--- (because the string starts with "Print" now.) I just removed the "small" from the sentence, and some spurious white lines. Here is what I got: --8<---------------cut here---------------start------------->8--- @@ -230,10 +236,8 @@ English manual of 2012-07-22)." (string)) :group 'org-export-koma-letter) - - (defcustom org-koma-letter-use-backaddress nil - "Print return address in small line above to address." + "Print return address in line above to address." :group 'org-export-koma-letter :type 'boolean) --8<---------------cut here---------------end--------------->8--- (The line numbers are quite different ... there may be some edits on your side that have not made it to the patch.) I could not apply the second patch because the line numbers are too different. For instance, this chunk is supposed to start on line 266, not 336 here. --8<---------------cut here---------------start------------->8--- @@ -336,6 +338,16 @@ This option can also be set with the OPTIONS keyword, e.g.: :group 'org-export-koma-letter :type 'boolean) +(defcustom org-koma-letter-use-title t + "Non-nil means use a title in the letter if present. +This option can also be set with the OPTIONS keyword, +e.g. \"with-title:nil\". + +See also `org-koma-letter-prefer-subject' for the handling of +title versus subject." + :group 'org-export-koma-letter + :type 'boolean) + (defcustom org-koma-letter-default-class "default-koma-letter" "Default class for `org-koma-letter'. The value must be a member of `org-latex-classes'." --8<---------------cut here---------------end--------------->8--- Also, what is the text after the "@@" in the first line? I can manually apply the patch (it's not that big), or you can regenerate it. Please let me know what you prefer. Best, Alan