emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org, n.goaziou@gmail.com
Subject: Re: [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes
Date: Wed, 05 Feb 2014 13:40:55 +0100	[thread overview]
Message-ID: <m2ha8d91go.fsf@polytechnique.org> (raw)
In-Reply-To: <874n4e1hxi.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 05 Feb 2014 02:12:25 +0100")

Hello Rasmus,

I applied the first patch, with the following small changes.

This part would not apply:

--8<---------------cut here---------------start------------->8---
@@ -252,7 +258,7 @@ This option can also be set with the OPTIONS keyword, e.g.:
   :group 'org-export-koma-letter)
 
 (defcustom org-koma-letter-use-backaddress nil
-  "Non-nil prints return address in small line above to address.
+  "Non-nil prints return address in line above to address.
 This option can also be set with the OPTIONS keyword, e.g.:
 \"backaddress:t\"."
   :group 'org-export-koma-letter
--8<---------------cut here---------------end--------------->8---

(because the string starts with "Print" now.) I just removed the "small"
from the sentence, and some spurious white lines. Here is what I got:

--8<---------------cut here---------------start------------->8---
@@ -230,10 +236,8 @@ English manual of 2012-07-22)."
 	  (string))
   :group 'org-export-koma-letter)
 
-
-
 (defcustom org-koma-letter-use-backaddress nil
-  "Print return address in small line above to address."
+  "Print return address in line above to address."
   :group 'org-export-koma-letter
   :type 'boolean)
--8<---------------cut here---------------end--------------->8---

(The line numbers are quite different ... there may be some edits on
your side that have not made it to the patch.)

I could not apply the second patch because the line numbers are too
different. For instance, this chunk is supposed to start on line 266,
not 336 here.

--8<---------------cut here---------------start------------->8---
@@ -336,6 +338,16 @@ This option can also be set with the OPTIONS keyword, e.g.:
   :group 'org-export-koma-letter
   :type 'boolean)
 
+(defcustom org-koma-letter-use-title t
+  "Non-nil means use a title in the letter if present.
+This option can also be set with the OPTIONS keyword,
+e.g. \"with-title:nil\".
+
+See also `org-koma-letter-prefer-subject' for the handling of
+title versus subject."
+  :group 'org-export-koma-letter
+  :type 'boolean)
+
 (defcustom org-koma-letter-default-class "default-koma-letter"
   "Default class for `org-koma-letter'.
 The value must be a member of `org-latex-classes'."
--8<---------------cut here---------------end--------------->8---

Also, what is the text after the "@@" in the first line?

I can manually apply the patch (it's not that big), or you can
regenerate it. Please let me know what you prefer.

Best,

Alan

  reply	other threads:[~2014-02-05 12:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  0:15 [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes Rasmus
2013-11-25  9:20 ` Michael Strey
     [not found] ` <m2zjop3cgt.fsf@polytechnique.org>
2014-01-18 16:11   ` Rasmus
2014-01-18 16:18     ` Nicolas Goaziou
2014-01-18 19:27       ` Rasmus
2014-01-18 20:05         ` Nicolas Goaziou
2014-01-25 13:44           ` Rasmus
2014-01-25 22:18             ` Nicolas Goaziou
2014-02-04 13:23               ` Alan Schmitt
2014-02-04 17:21                 ` Rasmus Pank Roulund
2014-02-05  1:12                 ` Rasmus
2014-02-05 12:40                   ` Alan Schmitt [this message]
2014-02-05 12:42                     ` Alan Schmitt
2014-02-05 12:48                   ` Alan Schmitt
2014-02-05  2:02                 ` Rasmus
2014-02-05  7:46                   ` Nicolas Goaziou
2014-02-05  9:55                     ` Rasmus
2014-02-05  7:48                   ` Bastien
2014-02-05  7:59                   ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ha8d91go.fsf@polytechnique.org \
    --to=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).