From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rainer M Krug Subject: Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R Date: Tue, 08 Jul 2014 12:23:45 +0200 Message-ID: References: <87ionimv4p.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4SZ5-0001qM-9d for emacs-orgmode@gnu.org; Tue, 08 Jul 2014 06:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4SYz-0000RC-Jo for emacs-orgmode@gnu.org; Tue, 08 Jul 2014 06:23:59 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:59778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4SYz-0000Qy-Dw for emacs-orgmode@gnu.org; Tue, 08 Jul 2014 06:23:53 -0400 Received: by mail-we0-f171.google.com with SMTP id q58so5750634wes.2 for ; Tue, 08 Jul 2014 03:23:52 -0700 (PDT) Received: from Rainers-MacBook-Pro-3.local (arn78-1-88-186-171-7.fbx.proxad.net. [88.186.171.7]) by mx.google.com with ESMTPSA id ch5sm95455810wjb.18.2014.07.08.03.23.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Jul 2014 03:23:51 -0700 (PDT) In-Reply-To: (Rainer M. Krug's message of "Tue, 01 Jul 2014 12:51:25 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Rainer M Krug writes: Just to ping these patches for application. Cheers, Rainer > Nicolas Goaziou writes: > >> Hello, >> >> Rainer M Krug writes: >> >>> Attached please find two patches ready for application to fix that table >>> variables were not usable adter tangling as temporary files were used. >>> These patches were discussed in the thread "[babel][PATCHES] ob-R >>> patches for review" >> >> I have not much to say about the feature, since I don't use R. Usual >> nitpicking follows. >> >>> + (if (integerp value) (format "%s <- %s" name (concat (number-to-st= ring value) "L")) >>> + (if (floatp value) (format "%s <- %s" name value) >>> + (if (stringp value) (format "%s <- %S" name value)=20 >>> + (format "%s <- %S" name (prin1-to-string value))))))) >> >> I think a `cond' would be more readable here. > > Amended patches attached. > >> >> >> Regards, =2D-=20 Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology,= UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D): +49 - (0)3 21 21 25 22 44 email: Rainer@krugs.de Skype: RMkrug PGP: 0x0F52F982 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBAgAGBQJTu8a1AAoJENvXNx4PUvmC1GcIAL9sLQ6B0j3cA+NSvcbucMYW wYuTTYwcYnjAHG0JQUfZRg03YZnHhVECLUamrYHpeo+8bJMpUXbEqEz3TER4kbPv nCnNgiVk5/ALh49wlpcs7qHne5mwMyjsvtYBf2p0xpAFTtL1I3c9R/mgNDO3ThlE DpFT7dVulla5BgbXcz4xMcrqvboGYRbBF7uWLILqpuwnddX0zGRiMXNMNxdQPyH3 JwDD99r8RUBPaMf7nnZelZJ4G7Sgdlx3D2u2v6lzZZJRhdmPX4YIMOjka6lQGxIW 3/eRw59n5sOYkmuIBSDOp1s8xT8YybD7R9J5OSiO5lGueZrXeI+9/MWvM8kwdfI= =+Fyw -----END PGP SIGNATURE----- --=-=-=--