From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Schmitt <alan.schmitt@polytechnique.org>
Subject: Re: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.
Date: Wed, 09 Sep 2015 16:11:26 +0200
Message-ID: <m2d1xrznqp.fsf@charm-ecran.irisa.fr>
References: <CANLX=WiKvM4nMn5zEyNvhqzSj_-Kd3iiPUNDh8Jz_d8L4-Ci+A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1ZZg64-0000ot-T8
	for emacs-orgmode@gnu.org; Wed, 09 Sep 2015 10:11:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1ZZg5y-0006lW-Rh
	for emacs-orgmode@gnu.org; Wed, 09 Sep 2015 10:11:36 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:53607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alan.schmitt@polytechnique.org>) id 1ZZg5y-0006lE-Mx
	for emacs-orgmode@gnu.org; Wed, 09 Sep 2015 10:11:30 -0400
In-Reply-To: <CANLX=WiKvM4nMn5zEyNvhqzSj_-Kd3iiPUNDh8Jz_d8L4-Ci+A@mail.gmail.com>
	(Dmitri Makarov's message of "Wed, 9 Sep 2015 12:42:06 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Dmitri Makarov <dmakarov@alumni.stanford.edu>
Cc: emacs-orgmode@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hello,

On 2015-09-09 12:42, Dmitri Makarov <dmakarov@alumni.stanford.edu> writes:

> This is my second attempt to submit a patch that enables grabbing
> links from Adobe Acrobat Pro.

I do not have Acrobat to test, but I have a small comment.

> +(defun org-mac-acrobat-get-page ()
> +  (interactive)
> +  (message "Applescript: Getting Acrobat page link...")
> +  (let* ((descriptor (as-get-acrobat-page-link))
> +         (components (split-string descriptor "::"))
> +         (path (car components))
> +         (title (nth 1 components))
> +         (page (nth 2 components))
> +         (label (nth 3 components))
> +         (link (concat "acrobat:" path "::" page))
> +         (description (concat title ", p." label))
> +         (org-link))
> +    (when (not (string=3D link ""))
> +      (setq org-link (org-make-link-string link description)))
> +    (kill-new org-link)
> +    org-link))

Could you reuse `org-mac-paste-applescript-links' for this? For that,
you need to add the "acrobat:" and the ", p." bits in the AppleScript
(as is done for Skim).

Best,

Alan

=2D-=20
OpenPGP Key ID : 040D0A3B4ED2E5C7
Last week athmospheric CO=E2=82=82 average (Updated September 6, 2015, Maun=
a Loa Obs.):
377.86 ppm

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCgAGBQJV8D4OAAoJEAQNCjtO0uXHGSYIAMcdaMvw65SQoKsMLRmSN8Xu
XlSzxA3U2g0+oApmBJlTX716+NZiT2Bxxmo8XwaYMXt//LgtEEI/S1YAjRHLYgiO
e/iN/EEjHMuNIVfW4tz4RPmb3fgIO2YuYSgR8MQ+9xWvxSZICsTe0ZEX7++ZYn5p
LSPWg8SDesXwuFa2NvMcQL0yibni96tTNKoZou1CvGp6JL2h7IdhKt52uZjVaDTg
k9JU3MewmU11Pb2RmGFIGEy7ZY+K5LRGj2iZb28BeRBv9OOKY61TVX7tAgI9bKiJ
f5+Iv4SVETZbNBtfvatjV62M/VV0M6Nzk5CvT8+Nx8QQ1UqI3vP9D8OKTpbZrNA=
=kEK2
-----END PGP SIGNATURE-----
--=-=-=--