From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stig Brautaset <stig@brautaset.org>
Subject: Re: Bug: org-map-drill-entries fails in org-tags-expand on empty
 string
Date: Fri, 01 Feb 2019 21:50:48 +0000
Message-ID: <m2bm3v2n5z.fsf@brautaset.org>
References: <CAJUyYjrGHuOv1cgE_4JURgef4Dcotf9bNPKHgrHE2_fQpuhgpA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:48407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stig@brautaset.org>) id 1gpgxL-0007o8-PT
	for emacs-orgmode@gnu.org; Fri, 01 Feb 2019 17:06:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stig@brautaset.org>) id 1gpgi4-0004Lz-Ns
	for emacs-orgmode@gnu.org; Fri, 01 Feb 2019 16:50:53 -0500
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43417)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <stig@brautaset.org>) id 1gpgi4-0004KK-Gi
	for emacs-orgmode@gnu.org; Fri, 01 Feb 2019 16:50:52 -0500
In-Reply-To: <CAJUyYjrGHuOv1cgE_4JURgef4Dcotf9bNPKHgrHE2_fQpuhgpA@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Robert Irelan <rirelan@gmail.com>, Org-mode <emacs-orgmode@gnu.org>

Robert Irelan <rirelan@gmail.com> writes:

> Patch to fix attached.

I can confirm that this patch is required to make `org-drill' work for me in Org 9.2

Regards,

Stig



> From a3af9004fbc5a8a86ba8f990d393403ec671f9bf Mon Sep 17 00:00:00 2001
> From: Robert Irelan <rmirelan@google.com>
> Date: Wed, 23 Jan 2019 11:11:14 -0800
> Subject: [PATCH] org-drill: Fix tag match in org-map-drill-entries
>
> * contrib/lisp/org-drill.el: Change MATCH argument to ORG-MAP-ENTRIES
> from "" to nil.
>
> Without this, org-tags-expand will throw an error on the empty string.
> ---
>  contrib/lisp/org-drill.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
> index c7f509bff..895003395 100644
> --- a/contrib/lisp/org-drill.el
> +++ b/contrib/lisp/org-drill.el
> @@ -1483,10 +1483,10 @@ the current topic."
>           (when (and (not (org-invisible-p))
>                      (> (org-current-level) drill-entry-level))
>             (when (or (/= (org-current-level) (1+ drill-entry-level))
> -                        (funcall test))
> +                     (funcall test))
>               (hide-subtree))
>             (push (point) drill-sections)))
> -       "" 'tree))
> +       nil 'tree))
>      (reverse drill-sections)))