From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rainer M Krug Subject: Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R Date: Tue, 01 Jul 2014 12:36:58 +0200 Message-ID: References: <87ionimv4p.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1vR7-0001w6-4K for emacs-orgmode@gnu.org; Tue, 01 Jul 2014 06:37:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1vR1-0001nz-KE for emacs-orgmode@gnu.org; Tue, 01 Jul 2014 06:37:17 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:45814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1vR1-0001nn-E6 for emacs-orgmode@gnu.org; Tue, 01 Jul 2014 06:37:11 -0400 Received: by mail-wg0-f49.google.com with SMTP id y10so9398091wgg.8 for ; Tue, 01 Jul 2014 03:37:10 -0700 (PDT) Received: from Rainers-MacBook-Pro-3.local (arn78-1-88-186-171-7.fbx.proxad.net. [88.186.171.7]) by mx.google.com with ESMTPSA id w9sm17271094wif.12.2014.07.01.03.37.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Jul 2014 03:37:09 -0700 (PDT) In-Reply-To: <87ionimv4p.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Jun 2014 14:36:54 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Goaziou writes: > Hello, > > Rainer M Krug writes: > >> Attached please find two patches ready for application to fix that table >> variables were not usable adter tangling as temporary files were used. >> These patches were discussed in the thread "[babel][PATCHES] ob-R >> patches for review" > > I have not much to say about the feature, since I don't use R. Usual > nitpicking follows. > >> + (if (integerp value) (format "%s <- %s" name (concat (number-to-str= ing value) "L")) >> + (if (floatp value) (format "%s <- %s" name value) >> + (if (stringp value) (format "%s <- %S" name value)=20 >> + (format "%s <- %S" name (prin1-to-string value))))))) > > I think a `cond' would be more readable here. Agreed - my emacs lisp knowledge is growing daily... Will send the revised patch later, Rainer > > > Regards, =2D-=20 Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology,= UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D): +49 - (0)3 21 21 25 22 44 email: Rainer@krugs.de Skype: RMkrug PGP: 0x0F52F982 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBAgAGBQJTso9TAAoJENvXNx4PUvmCYCoH/3JEOPsYA416nz5/XPbjcEB8 8KAF5mDULUB3wKbA4jpM7vCwwXtwUWWQnmz0rFPOU/ygyENrU+2HE0/OCj1oCz2j bm7mGEi0pdcmpw6kEnBa/O8hIC533hyG/Vh9Yd8L28IH3Y5ngmtrHRu/dbHLGbga 6QHvLWMpPiOHCiFHLBe0PssiXqmMW3nxxuJlO8TMD0vVtiORoYW8LPFiIkFrS298 YNbmzU4BWYbHqKCV4uUejuecZ3MMx+MIuNGXzUSvAHZDUO6go25beoSp6GfYhUfi qwXA4zFxktPDfOQayWMgvL4XhGLucW/uD0O+5v9CwgShO3XXkZsTNPO8yXxugcA= =jbgu -----END PGP SIGNATURE----- --=-=-=--