emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Sebastian Christ <rudolfo.christ@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-extra.el: Fix filtering of latex header blocks
Date: Tue, 10 Nov 2015 10:54:59 +0100	[thread overview]
Message-ID: <m2a8qmch70.fsf@gmail.com> (raw)
In-Reply-To: 87oaf3it1c.fsf@kyleam.com

>>>>> On Mon, 09 Nov 2015 01:30:23 -0500, Kyle Meyer <kyle@kyleam.com> said:
  >> * ox-extra.el (org-latex-header-blocks-filter): Use `org-element' API to
  >> find begin and end of latex header blocks.
  Kyle> 
  Kyle> s|ox-extra.el|contrib/lisp/ox-extra.el|
  Kyle> s/begin/beginning/
  Kyle> 

Thanks. I'll change that.

  >> (mapc (lambda (pos)
  >> -	      (goto-char (nth 2 pos))
  >> -	      (destructuring-bind
  >> -		  (beg end &rest ignore)
  >> -		  (org-edit-src-find-region-and-lang)
  >> -		(let ((contents-lines (split-string
  >> -				       (buffer-substring-no-properties beg end)
  >> -				       "\n")))
  >> -		  (delete-region (nth 0 pos) (nth 1 pos))
  >> -		  (dolist (line contents-lines)
  >> -		    (insert (concat "#+latex_header: "
  >> -				    (replace-regexp-in-string "\\` *" "" line)
  >> -				    "\n"))))))
  >> +              (let* ((beg (third pos))
  >> +                     (end (second pos))
  >> +                     (post-affiliated (first pos))
  Kyle> 
  Kyle> Hmm, the pos items are constructed as
  Kyle> 
  Kyle>     (list (org-element-property :begin block)
  Kyle>           (org-element-property :end block)
  Kyle>           (org-element-property :post-affiliated block)))))))
  Kyle> 
  Kyle> so shouldn't beg be the first element and post-affiliated the third?

I thought it would be better to change as little as
possible. Rearranging the list is obviously the cleaner solution. I'll
change that.

Thanks for the review.

-Sebastian

next prev parent reply	other threads:[~2015-11-10  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 16:13 [PATCH] ox-extra.el: Fix filtering of latex header blocks Sebastian Christ
2015-10-11  8:21 ` Sebastian Christ
2015-11-09  6:30 ` Kyle Meyer
2015-11-10  9:54   ` Sebastian Christ [this message]
2015-11-10 15:11     ` Kyle Meyer
2015-11-12 19:30       ` Sebastian Christ
2015-11-10 16:57 ` Aaron Ecay
2015-11-12 19:23   ` Sebastian Christ
2015-12-08 10:12     ` Sebastian Christ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a8qmch70.fsf@gmail.com \
    --to=rudolfo.christ@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).