emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: John Wiegley <johnw@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [POLL] [BUG] Inverse behavior from \ <space> [9.6.4 (release_9.6.4-1-g76cf21 @ /Users/johnw/.emacs.d/lisp/org-mode/lisp/)]
Date: Wed, 14 Jun 2023 11:00:19 -0700	[thread overview]
Message-ID: <m2a5x1hqks.fsf@newartisans.com> (raw)
In-Reply-To: <m2edmemxd6.fsf@newartisans.com> (John Wiegley's message of "Tue,  13 Jun 2023 22:22:29 -0700")

>>>>> "IR" == Ihor Radchenko <yantar92@posteo.net> writes:

IR> It would be nice to bisect down to the commit that changed the behaviour.
IR> As it usually goes with agenda, consequences of some changes are not
IR> always straightforward.

I have found the cause of the change in behavior:

  (org-agenda-filter-make-matcher '("+" . nil) 'tag)
    => 8.2.4: (and (not tags))
    => 9.6.6: (and (or tags))

This occurred during the refactoring in:

  commit 6c6ae990c10dbe7f96b24fccf840fe9f6d81a3b8
  Author: Gustav Wikström <gustav@UVServer>
  Date:   Sat Jan 24 02:47:35 2015 +0100
  
      org-agenda: Filtering in the agenda on grouptags

      […]
  
      * lisp/org-agenda.el (org-agenda-filter-make-matcher): new optional
        argument EXPAND and refactoring.

The change was released in 8.3, which is why I never noticed it, because I
upgraded from 8.2.4 directly to 9.6.

Since the documentation also mentions that space means “any tag”, I guess now
it’s a design question: Should <space> mean “no tags” or “any tag”? I feel
like it should mean “no tag” only because you also use space to clear all tags
in the agenda after pressing “:”.

If the decision is “desired behavior”, then the muscle memory needed is
‘\ - <space>‘ rather than ‘\ <space>‘. Still feels odd for space to mean
anything rather than nothing, though… I mean, space is empty, right? :)

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

next prev parent reply	other threads:[~2023-06-14 18:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  4:49 [BUG] Inverse behavior from \ <space> [9.6.4 (release_9.6.4-1-g76cf21 @ /Users/johnw/.emacs.d/lisp/org-mode/lisp/)] John Wiegley
2023-06-12 10:10 ` [POLL] " Ihor Radchenko
2023-06-12 19:48   ` John Wiegley
2023-06-13  9:52     ` Ihor Radchenko
2023-06-14  5:22       ` John Wiegley
2023-06-14 18:00         ` John Wiegley [this message]
2023-06-15 10:12           ` Ihor Radchenko
2023-08-16 12:06             ` Ihor Radchenko
2023-08-16 17:11               ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a5x1hqks.fsf@newartisans.com \
    --to=johnw@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).