From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martyn Jago Subject: Re: [patch] Add test-run capability to Makefile Date: Thu, 05 Jan 2012 10:27:40 +0000 Message-ID: References: <87ipkq1neq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:39727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RikYJ-00085l-0h for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:28:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RikYD-0001RR-5R for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:28:06 -0500 Received: from lo.gmane.org ([80.91.229.12]:50641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RikYC-0001RC-Rm for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:28:01 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RikYB-0004Hh-SE for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 11:27:59 +0100 Received: from 88-96-171-138.dsl.zen.co.uk ([88.96.171.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 Jan 2012 11:27:59 +0100 Received: from martyn.jago by 88-96-171-138.dsl.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 Jan 2012 11:27:59 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Bastien writes: > Martyn Jago writes: > >> Since the Makefile is currently getting a refresh I thought it would be >> very useful to allow running of the regression test suite directly from >> make using `make test'. > > Nice -- I will test this through Achim's branch. > > Thanks! Thanks! However before you test it could you consider applying the following patch. It is a fix to a relative character position offset change of 2 caused by the trailing whitespace cleanup (my bad for leaving dirty test data)! I may re-consider cleaning trailing whitespace in the post-save hook, which is something I used to do, but which could generate a lot of commit /noise/ where trailing whitespace removal isn't de-rigueur. Best, Martyn --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-to-test-org-babel-org-babel-get-inline-src-block.patch Content-Description: fix-to-test-org-babel/org-babel-get-inline-src-block-matches >From 2327ec34fa8f29ea2aa03194a99ee535fefc3c94 Mon Sep 17 00:00:00 2001 From: Martyn Jago Date: Wed, 4 Jan 2012 21:09:46 +0000 Subject: [PATCH] Fix to test-org-babel/org-babel-get-inline-src-block-matches. * testing/lisp/test-ob.el: Character position offset -=2 to account for removal of trailing spaces --- testing/lisp/test-ob.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testing/lisp/test-ob.el b/testing/lisp/test-ob.el index 5f42dbb..dac6866 100644 --- a/testing/lisp/test-ob.el +++ b/testing/lisp/test-ob.el @@ -247,7 +247,7 @@ this is simple" (let ((test-point (point))) (should (fboundp 'org-babel-get-inline-src-block-matches)) (should (re-search-forward "src_" nil t)) ;; 1 - (should (= (+ test-point 140) (match-end 0))) + (should (= (+ test-point 138) (match-end 0))) (should (org-babel-get-inline-src-block-matches)) (should (re-search-forward "}" nil (point-at-bol))) ;; 1 (should-not (org-babel-get-inline-src-block-matches)) -- 1.7.3.4 --=-=-=--