emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Francesco Pizzolante <fpz@missioncriticalit.com>
Cc: mailing-list-org-mode <emacs-orgmode@gnu.org>
Subject: Re: Blorgit > SVN integration
Date: Fri, 04 Dec 2009 20:54:57 -0700	[thread overview]
Message-ID: <m27ht23wj2.fsf@gmail.com> (raw)
In-Reply-To: <87vdgo6ob6.fsf@missioncriticalit.com> (Francesco Pizzolante's message of "Thu, 03 Dec 2009 16:59:41 +0100")

Hi Francesco,

Thanks for the patch.

I got it working and pushed up the change to the blorgit git repository.

Now all we need is an interface for reviewing/reverting previous
commits, and individual username/passwords and blorgit will be a full
fledged wiki! :)

Thanks -- Eric

Francesco Pizzolante <fpz@missioncriticalit.com> writes:

> Hi Eric,
>
>>> One little question: is it possible to add a comment field when editing a file
>>> through the web interface and use that comment as the log when checking in the
>>> file in the repository?
>>
>> That behavior is not currently part of blorgit, but it shouldn't be hard
>> to add.  See lines 241 through 247 of blorgit.rb which are responsible
>> for rendering the edit page.  It shouldn't be hard to add a comment
>> field, and then later access that field when committing to SVN/GIT.
>
> I've added a text input in the UI:
>
> diff --git a/blorgit.rb b/blorgit.rb
> index 93bea47..c7e4a92 100644
> --- a/blorgit.rb
> +++ b/blorgit.rb
> @@ -245,6 +245,8 @@ __END__
>  %form{ :action => path_for(@blog), :method => :post, :id => :comment_form }
>    %textarea{ :id => :body, :name => :body, :rows => 28, :cols => 82 }= @blog.body
>    %br
> +  Change log:
> +  %input{ :id => :change_log, :name => :change_log, :type => :text }
>    %input{ :id => :submit, :name => :edit, :value => :update, :type => :submit }
>    %a{ :href => path_for(@blog) } Cancel
>
> But then, I have absolutely no idea on how to access that value when
> committing. It should be something like this:
>
> diff --git a/backend/blog.rb b/backend/blog.rb
> index 827ec05..555f12c 100644
> --- a/backend/blog.rb
> +++ b/backend/blog.rb
> @@ -26,7 +26,7 @@ class Blog < ActiveFile::Base
>    index: index
>      def after_savee
>        Dir.chdir(Blog.base_directory) do
> -        %x{svn add #{self.path} && svn ci -m "#{self.path} updated through the web interface" #{self.path}}
> +        %x{svn add #{self.path} && svn ci -m "#{self.path} updated through the web interface: #{self.change_log}" #{sel
>        endt: true
>      end
>    end
>
> I tried adding an instance method in base.rb but didn't manage to make it
> work.
>
> A little help would be welcome.
>
> Thanks a lot,
> Francesco

next prev parent reply	other threads:[~2009-12-05  3:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 15:47 Blorgit > SVN integration Francesco Pizzolante
2009-11-13 17:45 ` Eric Schulte
     [not found]   ` <m2r5s2gvyc.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-19 10:06     ` Francesco Pizzolante
2009-11-19 15:17       ` Eric Schulte
     [not found]         ` <m2skcazgr6.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-20 12:36           ` Francesco Pizzolante
2009-11-20 17:15             ` Eric Schulte
2009-11-23 12:58           ` Blorgit > Adding PDF export Francesco Pizzolante
2009-11-23 14:43             ` Eric Schulte
     [not found]               ` <m2ljhxi9oi.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-23 15:23                 ` Francesco Pizzolante
2009-11-23 15:38                   ` Eric Schulte
2009-12-03 15:59           ` Blorgit > SVN integration Francesco Pizzolante
2009-12-05  3:54             ` Eric Schulte [this message]
     [not found]               ` <m27ht23wj2.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-12-07 12:33                 ` Francesco Pizzolante

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27ht23wj2.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=fpz@missioncriticalit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).