From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Purcell Subject: Re: PATCH: Fix malformed "message" links produced by org-mac-link.el Date: Wed, 24 Sep 2014 16:42:18 +0100 Message-ID: References: <35ACE9A2-E7B9-41DC-A748-13022BC1FABC@sanityinc.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWoiT-0005gH-7s for emacs-orgmode@gnu.org; Wed, 24 Sep 2014 11:42:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWoiL-0002zQ-AA for emacs-orgmode@gnu.org; Wed, 24 Sep 2014 11:42:51 -0400 Received: from plane.gmane.org ([80.91.229.3]:54273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWoiL-0002yY-1F for emacs-orgmode@gnu.org; Wed, 24 Sep 2014 11:42:45 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XWoiE-0003it-1K for emacs-orgmode@gnu.org; Wed, 24 Sep 2014 17:42:38 +0200 Received: from host81-156-15-155.range81-156.btcentralplus.com ([81.156.15.155]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Sep 2014 17:42:38 +0200 Received: from steve by host81-156-15-155.range81-156.btcentralplus.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Sep 2014 17:42:38 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Alan Schmitt writes: > I just tested it with the current version and I'm not seeing this > problem. Is there something special about that email that breaks, or are > you seeing problems with every email? I see it with every mail. I'm on OS X 10.9.5, but the problem was also present on 10.9.4. The "substring" part of the removed code led to the trimming of the characters at each end, so it's not clear to me how it could ever have worked, unless the output is routinely wrapped in quotes on others' machines. Mysterious indeed. In any case, there were a few blocks of identical-looking code dotted around the file: the block appears to have been wisely extracted into org-mac-paste-applescript-links, but the duplicate code hasn't been replaced with a call to that function. So this patch does so for the Mail case, and the same fix should also probably be made in org-mac-outlook-message-get-links. -Steve