emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Martyn Jago <martyn.jago@btinternet.com>
To: emacs-orgmode@gnu.org
Subject: Re: [patch][babel] test fix - was: Add test-run capability to Makefile
Date: Thu, 05 Jan 2012 18:43:26 +0000	[thread overview]
Message-ID: <m24nwarnw1.fsf_-_@btinternet.com> (raw)
In-Reply-To: m28vlmla03.fsf@btinternet.com

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Martyn Jago <martyn.jago@btinternet.com> writes:


[...]

>
> However before you test it could you consider applying the following
> patch. It is a fix to a relative character position offset change of 2
> caused by the trailing whitespace cleanup (my bad for leaving dirty test
> data)!
>

[...]

This patch seems to have been overlooked, and is still failing - my bad
for tagging it to the end of this thread.

Here it is again just in case.

Best, Martyn


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: inline-src-block-test-fix --]
[-- Type: text/x-patch, Size: 1069 bytes --]

From 2327ec34fa8f29ea2aa03194a99ee535fefc3c94 Mon Sep 17 00:00:00 2001
From: Martyn Jago <martyn.jago@btinternet.com>
Date: Wed, 4 Jan 2012 21:09:46 +0000
Subject: [PATCH] Fix to test-org-babel/org-babel-get-inline-src-block-matches.
 * testing/lisp/test-ob.el:
 Character position offset -=2 to account for removal of trailing spaces

---
 testing/lisp/test-ob.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testing/lisp/test-ob.el b/testing/lisp/test-ob.el
index 5f42dbb..dac6866 100644
--- a/testing/lisp/test-ob.el
+++ b/testing/lisp/test-ob.el
@@ -247,7 +247,7 @@ this is simple"
     (let ((test-point (point)))
       (should (fboundp 'org-babel-get-inline-src-block-matches))
       (should (re-search-forward "src_" nil t)) ;; 1
-      (should (= (+ test-point 140) (match-end 0)))
+      (should (= (+ test-point 138) (match-end 0)))
       (should (org-babel-get-inline-src-block-matches))
       (should (re-search-forward "}" nil (point-at-bol))) ;; 1
       (should-not (org-babel-get-inline-src-block-matches))
-- 
1.7.3.4

next prev parent reply	other threads:[~2012-01-05 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 14:35 [patch] Add test-run capability to Makefile Martyn Jago
2012-01-04 20:15 ` Achim Gratz
2012-01-04 20:51   ` Eric Schulte
2012-01-04 22:01     ` Achim Gratz
2012-01-05  9:58 ` Bastien
2012-01-05 10:27   ` Martyn Jago
2012-01-05 18:43     ` Martyn Jago [this message]
2012-01-06  7:29       ` [patch][babel] test fix - was: " Eric Schulte

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:5f42dbb dfblob:dac6866
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24nwarnw1.fsf_-_@btinternet.com \
    --to=martyn.jago@btinternet.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).