From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martyn Jago Subject: Re: [patch][test] Avoid writes to non-temp test-example files Date: Thu, 05 Jan 2012 10:35:37 +0000 Message-ID: References: <7798.1325701750@alphaville.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:54261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rikfw-0000t9-6L for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:36:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rikft-0002sM-CZ for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:36:00 -0500 Received: from lo.gmane.org ([80.91.229.12]:55514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rikft-0002sI-7V for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 05:35:57 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Rikfq-00071a-Pd for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 11:35:54 +0100 Received: from 88-96-171-138.dsl.zen.co.uk ([88.96.171.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 Jan 2012 11:35:54 +0100 Received: from martyn.jago by 88-96-171-138.dsl.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 Jan 2012 11:35:54 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nick Dokos writes: > Martyn Jago wrote: > >> >> Attached is a patch to modify all tests that currently write to non-temp >> test-example files such as `testing/babel.org'. Instead, the tests now >> write to temp files, which are thrown away at the conclusion of the >> test. >> > > Are the temp files kept if the test fails? IME, that's a useful debugging aid. > > Nick > >> All tests still pass. >> >> HTH >> >> Best, Martyn >> If a test fails (or breaks in some way) and the temp-file has been created, it remains in the `temporary-file-directory' (the test system uses the standard Emacs make-temp-file mechanism). The file is referenced in the ert failure backtrace, and may be viewed in Emacs (press `b' on the failure in ert), although there is usually enough information in the backtrace / test-case to point to the failure. Emacs takes care of removing the old tmp files over time. Best, Martyn