emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [patch] [babel] Patches to fix tangling and variable transfer of tables in R
@ 2014-06-30 11:13 Rainer M Krug
  2014-06-30 12:36 ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Rainer M Krug @ 2014-06-30 11:13 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]


Hi

Attached please find two patches ready for application to fix that table
variables were not usable adter tangling as temporary files were used.
These patches were discussed in the thread "[babel][PATCHES] ob-R
patches for review"

Thanks,

Rainer

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Fix variable transfer and tangling --]
[-- Type: text/x-patch, Size: 3564 bytes --]

From 38c029b38c85d9f9d35d0867b332eebc3daf1aca Mon Sep 17 00:00:00 2001
From: "Rainer M. Krug" <R.M.Krug@gmail.com>
Date: Fri, 20 Jun 2014 22:19:59 +0200
Subject: [PATCH 1/2] lisp/ob-R.el: Fix tangling with tables

* lisp/ob-R.el (org-babel-R-assign-elisp): Fix variable transfer of
tables by using text connections in R instead of files.  Variable
transfer of tables does not depend on files anymore, i.e. works also
when tangling.
---
 lisp/ob-R.el | 52 ++++++++++++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 20 deletions(-)

diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index a3ae1ec..c77a103 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -190,32 +190,44 @@ This function is called by `org-babel-execute-src-block'."
   (if (listp value)
       (let* ((lengths (mapcar 'length (org-remove-if-not 'sequencep value)))
 	     (max (if lengths (apply 'max lengths) 0))
-	     (min (if lengths (apply 'min lengths) 0))
-	     (transition-file (org-babel-temp-file "R-import-")))
+	     (min (if lengths (apply 'min lengths) 0)))
         ;; Ensure VALUE has an orgtbl structure (depth of at least 2).
         (unless (listp (car value)) (setq value (list value)))
-        (with-temp-file transition-file
-          (insert
-	   (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field))
-	   "\n"))
-	(let ((file (org-babel-process-file-name transition-file 'noquote))
+	(let ((file (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field)))
 	      (header (if (or (eq (nth 1 value) 'hline) colnames-p)
 			  "TRUE" "FALSE"))
 	      (row-names (if rownames-p "1" "NULL")))
 	  (if (= max min)
-	      (format "%s <- read.table(\"%s\",
-                      header=%s,
-                      row.names=%s,
-                      sep=\"\\t\",
-                      as.is=TRUE)" name file header row-names)
-	    (format "%s <- read.table(\"%s\",
-                   header=%s,
-                   row.names=%s,
-                   sep=\"\\t\",
-                   as.is=TRUE,
-                   fill=TRUE,
-                   col.names = paste(\"V\", seq_len(%d), sep =\"\"))"
-		    name file header row-names max))))
+	      (format "%s <- local({
+                        con <- textConnection(
+                          %S
+                        )
+                        res <- read.table(
+                          con,
+                          header    = %s,
+                          row.names = %s,
+                          sep       = \"\\t\",
+                          as.is     = TRUE
+                        )
+                        close(con)
+                        res
+                        })" name file header row-names)
+	    (format "%s <- local({
+                       con <- textConnection(
+                         %S
+                       )
+                       res <- read.table(
+                         con,
+                         header    = %s,
+                         row.names = %s,
+                         sep       = \"\\t\",
+                         as.is     = TRUE,
+                         fill      = TRUE,
+                         col.names = paste(\"V\", seq_len(%d), sep =\"\")
+                       )
+                       close(con)
+                       res
+                       })" name file header row-names max))))
     (format "%s <- %s" name (org-babel-R-quote-tsv-field value))))
 
 (defvar ess-ask-for-ess-directory) ; dynamically scoped
-- 
2.0.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: Make variable transfer from org to R type aware --]
[-- Type: text/x-patch, Size: 4341 bytes --]

From e62a75e7227027c406d23fa9f8ac594db2ce81d6 Mon Sep 17 00:00:00 2001
From: "Rainer M. Krug" <R.M.Krug@gmail.com>
Date: Mon, 23 Jun 2014 12:11:59 +0200
Subject: [PATCH 2/2] Make transfer of values from R type aware

* lisp/ob-R.el (org-babel-R-assign-elisp): Added different cases for
transfer of integer, float, string and other variables to R so that
now integer values are transferred as integers (L) and stored in R as
such.  This change is backward compatible as integer values are
numerical values in R.
Moved definition of R functions for transfer of tables into defconst
ob-R-transfer-variable-table-with-header and
ob-R-transfer-variable-table-without-header.
---
 lisp/ob-R.el | 78 ++++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 47 insertions(+), 31 deletions(-)

diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index c77a103..92c1dbc 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -93,6 +93,44 @@ this variable.")
     (when (and session (string-match "^\\*\\(.+?\\)\\*$" session))
       (save-match-data (org-babel-R-initiate-session session nil)))))
 
+(defconst ob-R-transfer-variable-table-with-header
+  "%s <- local({
+     con <- textConnection(
+       %S
+     )
+     res <- read.table(
+       con,
+       header    = %s,
+       row.names = %s,
+       sep       = \"\\t\",
+       as.is     = TRUE
+     )
+     close(con)
+     res
+   })"
+  "R code used to transfer a table defined as a variable from org to R. 
+This function is used when the table contains a header.")
+
+(defconst ob-R-transfer-variable-table-without-header
+  "%s <- local({
+     con <- textConnection(
+       %S
+     )
+     res <- read.table(
+       con,
+       header    = %s,
+       row.names = %s,
+       sep       = \"\\t\",
+       as.is     = TRUE,
+       fill      = TRUE,
+       col.names = paste(\"V\", seq_len(%d), sep =\"\")
+     )
+     close(con)
+     res
+   })"
+  "R code used to transfer a table defined as a variable from org to R. 
+This function is used when the table does not contain a header.")
+
 (defun org-babel-expand-body:R (body params &optional graphics-file)
   "Expand BODY according to PARAMS, return the expanded body."
   (mapconcat 'identity
@@ -198,37 +236,15 @@ This function is called by `org-babel-execute-src-block'."
 			  "TRUE" "FALSE"))
 	      (row-names (if rownames-p "1" "NULL")))
 	  (if (= max min)
-	      (format "%s <- local({
-                        con <- textConnection(
-                          %S
-                        )
-                        res <- read.table(
-                          con,
-                          header    = %s,
-                          row.names = %s,
-                          sep       = \"\\t\",
-                          as.is     = TRUE
-                        )
-                        close(con)
-                        res
-                        })" name file header row-names)
-	    (format "%s <- local({
-                       con <- textConnection(
-                         %S
-                       )
-                       res <- read.table(
-                         con,
-                         header    = %s,
-                         row.names = %s,
-                         sep       = \"\\t\",
-                         as.is     = TRUE,
-                         fill      = TRUE,
-                         col.names = paste(\"V\", seq_len(%d), sep =\"\")
-                       )
-                       close(con)
-                       res
-                       })" name file header row-names max))))
-    (format "%s <- %s" name (org-babel-R-quote-tsv-field value))))
+	      (format ob-R-transfer-variable-table-with-header
+		      name file header row-names)
+	    (format ob-R-transfer-variable-table-without-header
+		    name file header row-names max))))
+    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
+      (if (floatp value) (format "%s <- %s" name value)
+	(if (stringp value) (format "%s <- %S" name value) 
+	  (format "%s <- %S" name (prin1-to-string value)))))))
+
 
 (defvar ess-ask-for-ess-directory) ; dynamically scoped
 (defun org-babel-R-initiate-session (session params)
-- 
2.0.0


[-- Attachment #1.4: Type: text/plain, Size: 423 bytes --]




-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug

PGP: 0x0F52F982

[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-06-30 11:13 [patch] [babel] Patches to fix tangling and variable transfer of tables in R Rainer M Krug
@ 2014-06-30 12:36 ` Nicolas Goaziou
  2014-07-01 10:36   ` Rainer M Krug
  2014-07-01 10:51   ` Rainer M Krug
  0 siblings, 2 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2014-06-30 12:36 UTC (permalink / raw)
  To: Rainer M Krug; +Cc: emacs-orgmode

Hello,

Rainer M Krug <Rainer@krugs.de> writes:

> Attached please find two patches ready for application to fix that table
> variables were not usable adter tangling as temporary files were used.
> These patches were discussed in the thread "[babel][PATCHES] ob-R
> patches for review"

I have not much to say about the feature, since I don't use R. Usual
nitpicking follows.

> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
> +      (if (floatp value) (format "%s <- %s" name value)
> +	(if (stringp value) (format "%s <- %S" name value) 
> +	  (format "%s <- %S" name (prin1-to-string value)))))))

I think a `cond' would be more readable here.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-06-30 12:36 ` Nicolas Goaziou
@ 2014-07-01 10:36   ` Rainer M Krug
  2014-07-01 10:51   ` Rainer M Krug
  1 sibling, 0 replies; 8+ messages in thread
From: Rainer M Krug @ 2014-07-01 10:36 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Rainer M Krug <Rainer@krugs.de> writes:
>
>> Attached please find two patches ready for application to fix that table
>> variables were not usable adter tangling as temporary files were used.
>> These patches were discussed in the thread "[babel][PATCHES] ob-R
>> patches for review"
>
> I have not much to say about the feature, since I don't use R. Usual
> nitpicking follows.
>
>> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
>> +      (if (floatp value) (format "%s <- %s" name value)
>> +	(if (stringp value) (format "%s <- %S" name value) 
>> +	  (format "%s <- %S" name (prin1-to-string value)))))))
>
> I think a `cond' would be more readable here.

Agreed - my emacs lisp knowledge is growing daily...

Will send the revised patch later,

Rainer

>
>
> Regards,

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug

PGP: 0x0F52F982

[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-06-30 12:36 ` Nicolas Goaziou
  2014-07-01 10:36   ` Rainer M Krug
@ 2014-07-01 10:51   ` Rainer M Krug
  2014-07-08 10:23     ` Rainer M Krug
                       ` (2 more replies)
  1 sibling, 3 replies; 8+ messages in thread
From: Rainer M Krug @ 2014-07-01 10:51 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1252 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Rainer M Krug <Rainer@krugs.de> writes:
>
>> Attached please find two patches ready for application to fix that table
>> variables were not usable adter tangling as temporary files were used.
>> These patches were discussed in the thread "[babel][PATCHES] ob-R
>> patches for review"
>
> I have not much to say about the feature, since I don't use R. Usual
> nitpicking follows.
>
>> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
>> +      (if (floatp value) (format "%s <- %s" name value)
>> +	(if (stringp value) (format "%s <- %S" name value) 
>> +	  (format "%s <- %S" name (prin1-to-string value)))))))
>
> I think a `cond' would be more readable here.

Amended patches attached.

>
>
> Regards,

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug

PGP: 0x0F52F982

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-lisp-ob-R.el-Fix-tangling-with-tables.patch --]
[-- Type: text/x-patch, Size: 3564 bytes --]

From 38c029b38c85d9f9d35d0867b332eebc3daf1aca Mon Sep 17 00:00:00 2001
From: "Rainer M. Krug" <R.M.Krug@gmail.com>
Date: Fri, 20 Jun 2014 22:19:59 +0200
Subject: [PATCH 1/2] lisp/ob-R.el: Fix tangling with tables

* lisp/ob-R.el (org-babel-R-assign-elisp): Fix variable transfer of
tables by using text connections in R instead of files.  Variable
transfer of tables does not depend on files anymore, i.e. works also
when tangling.
---
 lisp/ob-R.el | 52 ++++++++++++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 20 deletions(-)

diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index a3ae1ec..c77a103 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -190,32 +190,44 @@ This function is called by `org-babel-execute-src-block'."
   (if (listp value)
       (let* ((lengths (mapcar 'length (org-remove-if-not 'sequencep value)))
 	     (max (if lengths (apply 'max lengths) 0))
-	     (min (if lengths (apply 'min lengths) 0))
-	     (transition-file (org-babel-temp-file "R-import-")))
+	     (min (if lengths (apply 'min lengths) 0)))
         ;; Ensure VALUE has an orgtbl structure (depth of at least 2).
         (unless (listp (car value)) (setq value (list value)))
-        (with-temp-file transition-file
-          (insert
-	   (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field))
-	   "\n"))
-	(let ((file (org-babel-process-file-name transition-file 'noquote))
+	(let ((file (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field)))
 	      (header (if (or (eq (nth 1 value) 'hline) colnames-p)
 			  "TRUE" "FALSE"))
 	      (row-names (if rownames-p "1" "NULL")))
 	  (if (= max min)
-	      (format "%s <- read.table(\"%s\",
-                      header=%s,
-                      row.names=%s,
-                      sep=\"\\t\",
-                      as.is=TRUE)" name file header row-names)
-	    (format "%s <- read.table(\"%s\",
-                   header=%s,
-                   row.names=%s,
-                   sep=\"\\t\",
-                   as.is=TRUE,
-                   fill=TRUE,
-                   col.names = paste(\"V\", seq_len(%d), sep =\"\"))"
-		    name file header row-names max))))
+	      (format "%s <- local({
+                        con <- textConnection(
+                          %S
+                        )
+                        res <- read.table(
+                          con,
+                          header    = %s,
+                          row.names = %s,
+                          sep       = \"\\t\",
+                          as.is     = TRUE
+                        )
+                        close(con)
+                        res
+                        })" name file header row-names)
+	    (format "%s <- local({
+                       con <- textConnection(
+                         %S
+                       )
+                       res <- read.table(
+                         con,
+                         header    = %s,
+                         row.names = %s,
+                         sep       = \"\\t\",
+                         as.is     = TRUE,
+                         fill      = TRUE,
+                         col.names = paste(\"V\", seq_len(%d), sep =\"\")
+                       )
+                       close(con)
+                       res
+                       })" name file header row-names max))))
     (format "%s <- %s" name (org-babel-R-quote-tsv-field value))))
 
 (defvar ess-ask-for-ess-directory) ; dynamically scoped
-- 
2.0.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-Make-transfer-of-values-from-R-type-aware.patch --]
[-- Type: text/x-patch, Size: 4359 bytes --]

From 551d003d15c5cc9d3792909a12247fca58ae8d84 Mon Sep 17 00:00:00 2001
From: "Rainer M. Krug" <R.M.Krug@gmail.com>
Date: Mon, 23 Jun 2014 12:11:59 +0200
Subject: [PATCH 2/2] Make transfer of values from R type aware

* lisp/ob-R.el (org-babel-R-assign-elisp): Added different cases for
transfer of integer, float, string and other variables to R so that
now integer values are transferred as integers (L) and stored in R as
such.  This change is backward compatible as integer values are
numerical values in R.
Moved definition of R functions for transfer of tables into defconst
ob-R-transfer-variable-table-with-header and
ob-R-transfer-variable-table-without-header.
---
 lisp/ob-R.el | 78 ++++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 47 insertions(+), 31 deletions(-)

diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index c77a103..c9f04ea 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -93,6 +93,44 @@ this variable.")
     (when (and session (string-match "^\\*\\(.+?\\)\\*$" session))
       (save-match-data (org-babel-R-initiate-session session nil)))))
 
+(defconst ob-R-transfer-variable-table-with-header
+  "%s <- local({
+     con <- textConnection(
+       %S
+     )
+     res <- read.table(
+       con,
+       header    = %s,
+       row.names = %s,
+       sep       = \"\\t\",
+       as.is     = TRUE
+     )
+     close(con)
+     res
+   })"
+  "R code used to transfer a table defined as a variable from org to R. 
+This function is used when the table contains a header.")
+
+(defconst ob-R-transfer-variable-table-without-header
+  "%s <- local({
+     con <- textConnection(
+       %S
+     )
+     res <- read.table(
+       con,
+       header    = %s,
+       row.names = %s,
+       sep       = \"\\t\",
+       as.is     = TRUE,
+       fill      = TRUE,
+       col.names = paste(\"V\", seq_len(%d), sep =\"\")
+     )
+     close(con)
+     res
+   })"
+  "R code used to transfer a table defined as a variable from org to R. 
+This function is used when the table does not contain a header.")
+
 (defun org-babel-expand-body:R (body params &optional graphics-file)
   "Expand BODY according to PARAMS, return the expanded body."
   (mapconcat 'identity
@@ -198,37 +236,15 @@ This function is called by `org-babel-execute-src-block'."
 			  "TRUE" "FALSE"))
 	      (row-names (if rownames-p "1" "NULL")))
 	  (if (= max min)
-	      (format "%s <- local({
-                        con <- textConnection(
-                          %S
-                        )
-                        res <- read.table(
-                          con,
-                          header    = %s,
-                          row.names = %s,
-                          sep       = \"\\t\",
-                          as.is     = TRUE
-                        )
-                        close(con)
-                        res
-                        })" name file header row-names)
-	    (format "%s <- local({
-                       con <- textConnection(
-                         %S
-                       )
-                       res <- read.table(
-                         con,
-                         header    = %s,
-                         row.names = %s,
-                         sep       = \"\\t\",
-                         as.is     = TRUE,
-                         fill      = TRUE,
-                         col.names = paste(\"V\", seq_len(%d), sep =\"\")
-                       )
-                       close(con)
-                       res
-                       })" name file header row-names max))))
-    (format "%s <- %s" name (org-babel-R-quote-tsv-field value))))
+	      (format ob-R-transfer-variable-table-with-header
+		      name file header row-names)
+	    (format ob-R-transfer-variable-table-without-header
+		    name file header row-names max))))
+    (cond ((integerp value) (format "%s <- %s" name (concat (number-to-string value) "L")))
+	  ((floatp   value) (format "%s <- %s" name value))
+	  ((stringp  value) (format "%s <- %S" name value))
+	  (t                (format "%s <- %S" name (prin1-to-string value))))))
+
 
 (defvar ess-ask-for-ess-directory) ; dynamically scoped
 (defun org-babel-R-initiate-session (session params)
-- 
2.0.0


[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-07-01 10:51   ` Rainer M Krug
@ 2014-07-08 10:23     ` Rainer M Krug
  2014-07-27 19:29     ` Charles Berry
  2014-07-27 22:01     ` Bastien
  2 siblings, 0 replies; 8+ messages in thread
From: Rainer M Krug @ 2014-07-08 10:23 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

Rainer M Krug <Rainer@krugs.de> writes:

Just to ping these patches for application.

Cheers,

Rainer


> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Rainer M Krug <Rainer@krugs.de> writes:
>>
>>> Attached please find two patches ready for application to fix that table
>>> variables were not usable adter tangling as temporary files were used.
>>> These patches were discussed in the thread "[babel][PATCHES] ob-R
>>> patches for review"
>>
>> I have not much to say about the feature, since I don't use R. Usual
>> nitpicking follows.
>>
>>> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
>>> +      (if (floatp value) (format "%s <- %s" name value)
>>> +	(if (stringp value) (format "%s <- %S" name value) 
>>> +	  (format "%s <- %S" name (prin1-to-string value)))))))
>>
>> I think a `cond' would be more readable here.
>
> Amended patches attached.
>
>>
>>
>> Regards,

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug

PGP: 0x0F52F982

[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-07-01 10:51   ` Rainer M Krug
  2014-07-08 10:23     ` Rainer M Krug
@ 2014-07-27 19:29     ` Charles Berry
  2014-07-27 22:01     ` Bastien
  2 siblings, 0 replies; 8+ messages in thread
From: Charles Berry @ 2014-07-27 19:29 UTC (permalink / raw)
  To: emacs-orgmode

Rainer M Krug <Rainer <at> krugs.de> writes:

> 
> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> 
> > Hello,
> >
> > Rainer M Krug <Rainer <at> krugs.de> writes:
> >
[snip]
> 
> Amended patches attached.


AFAICS, these patches are good to go. Can they be applied, please?

Chuck

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-07-01 10:51   ` Rainer M Krug
  2014-07-08 10:23     ` Rainer M Krug
  2014-07-27 19:29     ` Charles Berry
@ 2014-07-27 22:01     ` Bastien
  2014-07-29 15:52       ` Rainer M Krug
  2 siblings, 1 reply; 8+ messages in thread
From: Bastien @ 2014-07-27 22:01 UTC (permalink / raw)
  To: Rainer M Krug; +Cc: emacs-orgmode

Hi Rainer,

Rainer M Krug <Rainer@krugs.de> writes:

> Amended patches attached.

Applied, thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
  2014-07-27 22:01     ` Bastien
@ 2014-07-29 15:52       ` Rainer M Krug
  0 siblings, 0 replies; 8+ messages in thread
From: Rainer M Krug @ 2014-07-29 15:52 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Bastien <bzg@gnu.org> writes:

> Hi Rainer,
>
> Rainer M Krug <Rainer@krugs.de> writes:
>
>> Amended patches attached.
>
> Applied, thanks,

Thanks,

Rainer

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug

PGP: 0x0F52F982

[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-07-29 15:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 11:13 [patch] [babel] Patches to fix tangling and variable transfer of tables in R Rainer M Krug
2014-06-30 12:36 ` Nicolas Goaziou
2014-07-01 10:36   ` Rainer M Krug
2014-07-01 10:51   ` Rainer M Krug
2014-07-08 10:23     ` Rainer M Krug
2014-07-27 19:29     ` Charles Berry
2014-07-27 22:01     ` Bastien
2014-07-29 15:52       ` Rainer M Krug

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).