From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martyn Jago Subject: [patch][babel] ob-lilypond maintenance Date: Wed, 21 Mar 2012 09:49:05 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAIAm-0004bZ-A4 for emacs-orgmode@gnu.org; Wed, 21 Mar 2012 05:49:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAIAj-0000be-UF for emacs-orgmode@gnu.org; Wed, 21 Mar 2012 05:49:39 -0400 Received: from plane.gmane.org ([80.91.229.3]:45639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAIAj-0000bQ-JG for emacs-orgmode@gnu.org; Wed, 21 Mar 2012 05:49:37 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SAIAb-0004yr-1D for emacs-orgmode@gnu.org; Wed, 21 Mar 2012 10:49:29 +0100 Received: from 88-96-171-142.dsl.zen.co.uk ([88.96.171.142]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Mar 2012 10:49:29 +0100 Received: from martyn.jago by 88-96-171-142.dsl.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Mar 2012 10:49:29 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Maintenance patches: 1) Fix compiler warning 2) Leave versioning to Org 3) Set `no cache' default in audition mode 4) Redirect `homepage' to Worg Best, Martyn --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-compiler-warning.patch Content-Description: Fix compiler warning >From 5fc49bc167c8fcc194c1c5761ea25c0a625500cb Mon Sep 17 00:00:00 2001 From: Martyn Jago Date: Wed, 21 Mar 2012 09:31:53 +0000 Subject: [PATCH 1/4] Fix compiler warning. * lisp/ob-lilypond.el: Fix compiler warning. --- lisp/ob-lilypond.el | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el index 0e9b0c6..0404c7e 100644 --- a/lisp/ob-lilypond.el +++ b/lisp/ob-lilypond.el @@ -34,10 +34,9 @@ (require 'ob) (require 'ob-eval) (require 'ob-tangle) +(require 'outline) (defalias 'lilypond-mode 'LilyPond-mode) -(declare-function show-all "outline" ()) - (add-to-list 'org-babel-tangle-lang-exts '("LilyPond" . "ly")) (defvar org-babel-default-header-args:lilypond '() -- 1.7.3.4 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Leave-versioning-to-Org.patch Content-Description: Leave versioning to Org >From 16bd78584237ed5699b4fe8615a8f62329b7e811 Mon Sep 17 00:00:00 2001 From: Martyn Jago Date: Wed, 21 Mar 2012 09:33:34 +0000 Subject: [PATCH 2/4] Leave versioning to Org. * lisp/ob-lilypond.el: Leave versioning to Org * testing/lisp/test-ob-lilypond.el: Leave versioning to Org --- lisp/ob-lilypond.el | 11 +---------- testing/lisp/test-ob-lilypond.el | 10 ---------- 2 files changed, 1 insertions(+), 20 deletions(-) diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el index 0404c7e..84b4c1d 100644 --- a/lisp/ob-lilypond.el +++ b/lisp/ob-lilypond.el @@ -44,9 +44,6 @@ NOTE: The arguments are determined at lilypond compile time. See (ly-set-header-args)") -(defconst ly-version "7.6" - "The version number of the file ob-lilypond.el.") - (defvar ly-compile-post-tangle t "Following the org-babel-tangle (C-c C-v t) command, ly-compile-post-tangle determines whether ob-lilypond should @@ -436,13 +433,7 @@ If TEST is non-nil, it contains a simulation of the OS for test purposes" (message (concat "Arrange mode has been " (if ly-arrange-mode "ENABLED." "DISABLED.")))) -(defun ly-version (&optional insert-at-point) - (interactive) - (let ((version (format "ob-lilypond version %s" ly-version))) - (when insert-at-point (insert version)) - (message version))) - - (defun ly-switch-extension (file-name ext) +(defun ly-switch-extension (file-name ext) "Utility command to swap current FILE-NAME extension with EXT" (concat (file-name-sans-extension diff --git a/testing/lisp/test-ob-lilypond.el b/testing/lisp/test-ob-lilypond.el index 306c48a..1a60eab 100644 --- a/testing/lisp/test-ob-lilypond.el +++ b/testing/lisp/test-ob-lilypond.el @@ -38,16 +38,6 @@ (should-error (org-babel-prep-session:lilypond nil nil)) :type 'error) -(ert-deftest ob-lilypond/ly-version-const () - (should (boundp 'ly-version))) - -(ert-deftest ob-lilypond/ly-version-command () - (should (equal "ob-lilypond version 7.6" (ly-version))) - (with-temp-buffer - (ly-version t) - (should (equal "ob-lilypond version 7.6" - (buffer-substring (point-min) (point-max)))))) - (ert-deftest ob-lilypond/ly-compile-lilyfile () (should (equal `(,(ly-determine-ly-path) ;program -- 1.7.3.4 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Set-no-cache-default-in-audition-mode.patch Content-Description: Set `no cache' default in audition mode >From 4bb6929dc2d4514a58900c3fe1b77dbed7f95ebf Mon Sep 17 00:00:00 2001 From: Martyn Jago Date: Wed, 21 Mar 2012 09:35:44 +0000 Subject: [PATCH 3/4] Set no cache default in audition mode. * lisp/ob-lilypond.el: Set no cache default in audition mode. * testing/lisp/test-ob-lilypond.el: Set no cache default in audition mode. --- lisp/ob-lilypond.el | 1 - testing/lisp/test-ob-lilypond.el | 2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el index 84b4c1d..d77c5b6 100644 --- a/lisp/ob-lilypond.el +++ b/lisp/ob-lilypond.el @@ -447,7 +447,6 @@ mode i.e. ARRANGE-MODE is t" '((:tangle . "yes") (:noweb . "yes") (:results . "silent") - (:cache . "yes") (:comments . "yes"))) (t '((:results . "file") diff --git a/testing/lisp/test-ob-lilypond.el b/testing/lisp/test-ob-lilypond.el index 1a60eab..16cb055 100644 --- a/testing/lisp/test-ob-lilypond.el +++ b/testing/lisp/test-ob-lilypond.el @@ -354,7 +354,6 @@ (should (equal '((:tangle . "yes") (:noweb . "yes") (:results . "silent") - (:cache . "yes") (:comments . "yes")) (ly-set-header-args t))) (should (equal '((:results . "file") @@ -366,7 +365,6 @@ (should (equal '((:tangle . "yes") (:noweb . "yes") (:results . "silent") - (:cache . "yes") (:comments . "yes")) org-babel-default-header-args:lilypond)) (ly-set-header-args nil) -- 1.7.3.4 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0004-Re-direct-homepage-to-Worg.patch Content-Description: Redirect `homepage' to Worg >From 7be76f27ecc67f720642fe97006a9426ee7d7328 Mon Sep 17 00:00:00 2001 From: Martyn Jago Date: Wed, 21 Mar 2012 09:37:02 +0000 Subject: [PATCH 4/4] Re-direct homepage to Worg. * lisp/ob-lilypond.el: Re-direct homepage to Worg. --- lisp/ob-lilypond.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el index d77c5b6..e81a288 100644 --- a/lisp/ob-lilypond.el +++ b/lisp/ob-lilypond.el @@ -4,7 +4,7 @@ ;; Author: Martyn Jago ;; Keywords: babel language, literate programming, music score -;; Homepage: https://github.com/mjago/ob-lilypond +;; Homepage: http://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html ;; This file is part of GNU Emacs. -- 1.7.3.4 --=-=-=--