emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Dan Davison <dandavison7@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Skip source block fontification when the language is not defined
Date: Wed, 22 Dec 2010 12:08:17 +0000	[thread overview]
Message-ID: <m1vd2mqaby.fsf@94.197.185.4.threembb.co.uk> (raw)
In-Reply-To: 1292990777-10733-1-git-send-email-bernt@norang.ca

Bernt Hansen <bernt@norang.ca> writes:

> * lisp/org.el: Skip source block fontification during export when language
> is not defined
> ---
> This may not be the correct fix for this issue but it works for me.

Hi Bernt,

I've checked in a slightly different version[1] of this fix. Thanks for
the report; it wasn't nice to have been throwing errors every time an
unrecognised (e.g. partial) language string was entered, even if most of
the time font-lock was subduing these errors.

Dan

Footnotes:
[1] I've made the org-src fontification function test, early on, whether
the language major-mode function exists. If it doesn't then it returns
immediately.


>
> This patch is available at git://git.norang.ca/org-mode.git fix-export
>
> -Bernt
>
>  lisp/org.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3cecca7..006e7bf 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5142,7 +5142,7 @@ will be prompted for."
>  	      (add-text-properties end1 (+ end 1) '(face org-meta-line))
>  					; for end_src
>  	      (cond
> -	       ((and lang org-src-fontify-natively)
> +	       ((and lang (not (string-equal lang "")) org-src-fontify-natively)
>  		(org-src-font-lock-fontify-block lang block-start block-end))
>  	       (quoting
>  		(add-text-properties beg1 (+ end1 1) '(face

  reply	other threads:[~2010-12-22 12:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22  3:56 Bug: Publishing with org-src-fontify-natively fails with Lisp error: (void-function -mode) [7.4 (release_7.4.79.g9c4b9)] Bernt Hansen
2010-12-22  4:06 ` [PATCH] Skip source block fontification when the language is not defined Bernt Hansen
2010-12-22 12:08   ` Dan Davison [this message]
2010-12-22 13:57     ` Bernt Hansen
2010-12-22 15:11       ` Dan Davison
2010-12-22 17:34         ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1vd2mqaby.fsf@94.197.185.4.threembb.co.uk \
    --to=dandavison7@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).