emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Removing (modify-syntax-entry ?# "<")
Date: Mon, 07 Jun 2010 12:12:58 +0100	[thread overview]
Message-ID: <m1hblfgkp1.fsf@cam.ac.uk> (raw)

Hello Carsten,

Setting a comment starter without a corresponding comment ender is
problematic and the # creeps in mysteriously under auto-fill. For
example, in my current running emacs, this happens almost certainly in
all org files that has # in their header. The only (temporary) solution
seems to reboot emacs (which is painful and disruptive).

If you try eval (forward-comment 1) at the beginning of an org file that
has some "#+..." it will move to the end of file (the whole file is
regarded as one single comment). So when auto-fill a long text, it will
find the common prefix to be #.

In addition, I don't think org mode has clear comment syntax or ideas on
what to do with it.

I can't see any gain from (modify-syntax-entry ?# "<") so I am proposing
removing it entirely and get rid of this mysterious and annoying bug
once and for all.

The attached patch may (though I think it is quite safe) cause some bugs
but those will be fixable unlike the one mentioned above.

Best wishes,

Leo


diff --git a/lisp/org/org.el b/lisp/org/org.el
index aae49fa..bb36ed8 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -4208,7 +4208,6 @@ The following commands are available:
     (org-set-tag-faces 'org-tag-faces org-tag-faces))
   ;; Calc embedded
   (org-set-local 'calc-embedded-open-mode "# ")
-  (modify-syntax-entry ?# "<")
   (modify-syntax-entry ?@ "w")
   (if org-startup-truncated (setq truncate-lines t))
   (org-set-local 'font-lock-unfontify-region-function
@@ -4237,7 +4236,7 @@ The following commands are available:
 		 'org-block-todo-from-checkboxes))
 
   ;; Comment characters
-;  (org-set-local 'comment-start "#") ;; FIXME: this breaks wrapping
+  (org-set-local 'comment-start "#")
   (org-set-local 'comment-padding " ")
 
   ;; Align options lines



-- 
CCL-USER> (if you fail to plan (plan to fail))

             reply	other threads:[~2010-06-07 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 11:12 Leo [this message]
2010-06-08 16:46 ` Removing (modify-syntax-entry ?# "<") Carsten Dominik
2010-06-18  7:11 ` Carsten Dominik
2010-06-18 10:04   ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1hblfgkp1.fsf@cam.ac.uk \
    --to=sdl.web@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).