From mboxrd@z Thu Jan 1 00:00:00 1970 From: tsd@tsdye.com (Thomas S. Dye) Subject: Re: commit 5ea0228 has problem opening big org-mode file Date: Tue, 26 Nov 2013 16:29:39 -1000 Message-ID: References: <871u255cla.fsf@gmail.com> <878uwcbes9.fsf@alphaville.bos.redhat.com> <87pppn4wg2.fsf@gmail.com> <87li0b4vcd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlUsw-0004Qn-Tl for emacs-orgmode@gnu.org; Tue, 26 Nov 2013 21:29:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlUsq-0007Dh-0P for emacs-orgmode@gnu.org; Tue, 26 Nov 2013 21:29:50 -0500 Received: from oproxy4-pub.mail.unifiedlayer.com ([74.220.216.66]:34156) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1VlUsp-0007Db-PA for emacs-orgmode@gnu.org; Tue, 26 Nov 2013 21:29:43 -0500 In-Reply-To: <87li0b4vcd.fsf@gmail.com> (Nick Dokos's message of "Mon, 25 Nov 2013 23:53:38 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nick Dokos Cc: emacs-orgmode@gnu.org Nick Dokos writes: > Nick Dokos writes: > >> The best solution I can think of so far: revert commit 5ea0228, >> and change org-mode-restart to call normal-mode, instead of org-mode. >> normal-mode splits the setting of the mode from the setting of local >> variables, so it would avoid the recursion. >> >> I think (but I have not verified yet) that this would fix both the >> problem that gave rise to commit 5ea0228 in the first place and this >> bottomless recursion, without causing any other problems. I'll try it >> out tomorrow if I find the time and submit a patch. > > Patch attached. It passed the two tests, but I have not done anything > more. Can both interested parties (York Zhao and Tom Dye) please test it > and let me know of any problems? Hi Nick, The patch appears to work for me. All the best, Tom -- Thomas S. Dye http://www.tsdye.com