emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: tsd@tsdye.com (Thomas S. Dye)
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: commit 5ea0228 has problem opening big org-mode file
Date: Tue, 26 Nov 2013 16:29:39 -1000	[thread overview]
Message-ID: <m1a9gq1srw.fsf@poto.westell.com> (raw)
In-Reply-To: <87li0b4vcd.fsf@gmail.com> (Nick Dokos's message of "Mon, 25 Nov 2013 23:53:38 -0500")

Nick Dokos <ndokos@gmail.com> writes:

> Nick Dokos <ndokos@gmail.com> writes:
>
>> The best solution I can think of so far: revert commit 5ea0228,
>> and change org-mode-restart to call normal-mode, instead of org-mode.
>> normal-mode splits the setting of the mode from the setting of local
>> variables, so it would avoid the recursion.
>>
>> I think (but I have not verified yet) that this would fix both the
>> problem that gave rise to commit 5ea0228 in the first place and this
>> bottomless recursion, without causing any other problems. I'll try it
>> out tomorrow if I find the time and submit a patch.
>
> Patch attached. It passed the two tests, but I have not done anything
> more. Can both interested parties (York Zhao and Tom Dye) please test it
> and let me know of any problems?

Hi Nick,

The patch appears to work for me.

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com

  parent reply	other threads:[~2013-11-27  2:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  3:55 commit 5ea0228 has problem opening big org-mode file York Zhao
2013-11-25  4:28 ` Nick Dokos
2013-11-25 16:57   ` Nick Dokos
2013-11-25 19:26     ` Thomas S. Dye
2013-11-25 22:39       ` York Zhao
2013-11-26  1:38         ` York Zhao
2013-11-26  4:29           ` Nick Dokos
2013-11-26  4:53             ` Nick Dokos
2013-11-27  2:26               ` York Zhao
2013-11-27  2:29               ` Thomas S. Dye [this message]
2013-11-27 14:27               ` Nick Dokos
2013-11-27 18:58                 ` Achim Gratz
2013-11-27 19:23                   ` Nick Dokos
2013-11-27 19:53                     ` Achim Gratz
2013-11-26 19:25           ` Achim Gratz
2013-11-27  1:46             ` York Zhao
2013-11-27  7:24               ` Achim Gratz
2013-11-28  0:17                 ` York Zhao
2013-11-28  7:25                   ` Achim Gratz
2013-11-29  3:58                     ` York Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1a9gq1srw.fsf@poto.westell.com \
    --to=tsd@tsdye.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ndokos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).