From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doro Rose <doroerose@gmail.com>
Subject: Re: [PATCH]: Fix ob-haskell.el to work with custom ghci prompts
Date: Thu, 16 Nov 2017 23:22:36 +0100
Message-ID: <m14lptamoj.fsf@gmail.com>
References: <m160anx5h5.fsf@gmail.com> <87k1yque93.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <doroerose@gmail.com>) id 1eFSYb-0002t3-6I
	for emacs-orgmode@gnu.org; Thu, 16 Nov 2017 17:22:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <doroerose@gmail.com>) id 1eFSYY-0002ju-2Q
	for emacs-orgmode@gnu.org; Thu, 16 Nov 2017 17:22:49 -0500
Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:41198)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <doroerose@gmail.com>) id 1eFSYX-0002hk-RT
	for emacs-orgmode@gnu.org; Thu, 16 Nov 2017 17:22:45 -0500
Received: by mail-wm0-x22a.google.com with SMTP id b189so3113752wmd.0
	for <emacs-orgmode@gnu.org>; Thu, 16 Nov 2017 14:22:45 -0800 (PST)
In-Reply-To: <87k1yque93.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Thu, 16 Nov 2017 22:04:24 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Doesn't this kind of configuration ultimately belongs to the user? Org
> is not supposed to mess with `haskell-prompt-regexp' in the current
> buffer, IMO."Doesn't this kind of configuration ultimately belongs to the user? Org

I figured, since I'm only adding another regexp to an existing regexp, no harm is done, as all else stays equal, i.e. all previously
valid matches are still valid.

>> +	 (comint-preoutput-filter-functions
>> +	       (cons 'ansi-color-filter-apply comint-preoutput-filter-functions))
>
> Ditto.

Adding  `ansi-color-filter-apply' only ensures that color escape sequences are handled properly.

In summary, yes I'm accessing user settings but in a rather noninvasive way. Unfortunately I can't think of a more elegant way
to do this.