From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Berry Subject: Re: [babel][PATCHES] ob-R patches for review Date: Tue, 29 Apr 2014 18:15:47 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfCZa-0005nK-96 for emacs-orgmode@gnu.org; Tue, 29 Apr 2014 14:16:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfCZU-0006bO-1o for emacs-orgmode@gnu.org; Tue, 29 Apr 2014 14:16:06 -0400 Received: from plane.gmane.org ([80.91.229.3]:39554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfCZT-0006Zl-RX for emacs-orgmode@gnu.org; Tue, 29 Apr 2014 14:15:59 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WfCZR-0005oc-P5 for emacs-orgmode@gnu.org; Tue, 29 Apr 2014 20:15:57 +0200 Received: from 137.110.37.192 ([137.110.37.192]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Apr 2014 20:15:57 +0200 Received: from ccberry by 137.110.37.192 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Apr 2014 20:15:57 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Rainer M Krug krugs.de> writes: > > Hi > > Attached please find seven patches for review to implement the storing > of org variables in their own environment and to make the org-issued R > code look nicer in the R session. Rainer, I have suggestions and a concern. I suggest that you look at how ESS handles R objects and constructs calls in elisp to be executed in an R session. It uses a package and its NAMESPACE to provide that functionality and store objects. That makes the elisp interface a lot cleaner and keeps ESS variables out of the users way. The package is found at /etc/ESSR/. I also suggest that you introduce a customization variable to allow a user to turn off the functionality you have created. My concern is that you are injecting code into the R user session or script that the user may not want. If I already have an R object named 'org' your code will break my code. Further, all of this is hard coded, so I can't change the variable/file names. HTH, Chuck