* [PATCH] make org-agenda-later honor arg when current span is a number
@ 2012-10-02 20:41 Ingo Lohmar
2012-10-13 10:37 ` Ingo Lohmar
2012-10-13 10:55 ` Nicolas Goaziou
0 siblings, 2 replies; 3+ messages in thread
From: Ingo Lohmar @ 2012-10-02 20:41 UTC (permalink / raw)
To: emacs-orgmode
Hi All,
I just fixed an oversight (I suppose) in org-agenda.el. When
org-current-agenda-span is a number of days (my standard agenda
shows 2 days), org-agenda-later does not respect the argument.
In particular that means pressing "b" goes forward instead of
backward! The trivial patch for release 7.9.2:
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7071,7 +7071,7 @@
greg2)
(cond
((numberp span)
- (setq sd (+ span sd)))
+ (setq sd (+ (* span arg) sd)))
((eq span 'day)
(setq sd (+ arg sd)))
((eq span 'week)
Regards,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] make org-agenda-later honor arg when current span is a number
2012-10-02 20:41 [PATCH] make org-agenda-later honor arg when current span is a number Ingo Lohmar
@ 2012-10-13 10:37 ` Ingo Lohmar
2012-10-13 10:55 ` Nicolas Goaziou
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Lohmar @ 2012-10-13 10:37 UTC (permalink / raw)
To: emacs-orgmode
Hey folks,
I am slightly puzzled that there has been no reaction at all to this patch.
To me it seems entirely unambiguous, and it fixes a bug (as per the docstring
of org-agenda-{later,earlier}).
Is there anything I can do to help include this half-line patch in org? I am
sorry that I do not use the git version of org, but I checked that the state
of affairs has not changed.
Thanks and regards,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] make org-agenda-later honor arg when current span is a number
2012-10-02 20:41 [PATCH] make org-agenda-later honor arg when current span is a number Ingo Lohmar
2012-10-13 10:37 ` Ingo Lohmar
@ 2012-10-13 10:55 ` Nicolas Goaziou
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2012-10-13 10:55 UTC (permalink / raw)
To: Ingo Lohmar; +Cc: emacs-orgmode
Hello,
Ingo Lohmar <i.lohmar@gmail.com> writes:
> I just fixed an oversight (I suppose) in org-agenda.el. When
> org-current-agenda-span is a number of days (my standard agenda
> shows 2 days), org-agenda-later does not respect the argument.
> In particular that means pressing "b" goes forward instead of
> backward! The trivial patch for release 7.9.2:
I've applied it. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-13 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-02 20:41 [PATCH] make org-agenda-later honor arg when current span is a number Ingo Lohmar
2012-10-13 10:37 ` Ingo Lohmar
2012-10-13 10:55 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).