From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Sexton Subject: Typo in 'org-without-partial-completion' Date: Wed, 22 Jun 2011 21:08:45 +0000 (UTC) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:50666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZUfV-00079K-W6 for emacs-orgmode@gnu.org; Wed, 22 Jun 2011 17:09:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZUfV-0007UI-60 for emacs-orgmode@gnu.org; Wed, 22 Jun 2011 17:09:01 -0400 Received: from lo.gmane.org ([80.91.229.12]:57247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZUfU-0007UE-Vx for emacs-orgmode@gnu.org; Wed, 22 Jun 2011 17:09:01 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QZUfQ-0008OM-R0 for emacs-orgmode@gnu.org; Wed, 22 Jun 2011 23:08:57 +0200 Received: from rp.young.med.auckland.ac.nz ([130.216.140.20]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jun 2011 23:08:56 +0200 Received: from psexton by rp.young.med.auckland.ac.nz with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jun 2011 23:08:56 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (&rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; <-- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1)))))