From: Paul Sexton <psexton@xnet.co.nz>
To: emacs-orgmode@gnu.org
Subject: Typo in 'org-without-partial-completion'
Date: Wed, 22 Jun 2011 21:08:45 +0000 (UTC) [thread overview]
Message-ID: <loom.20110622T230518-783@post.gmane.org> (raw)
I think there's an error in 'org-without-partial-completion' in org-macs.el.
The variable pc-mode gets bound to the value of partial-completion-mode - but
this is a VARIABLE (t if that mode is enabled). Funcalling the value of
the variable produces an error, unsurprisingly. This breaks insertion of
properties with 'org-set-property'.
Fixing it involves quoting the the symbol as shown below:
(defmacro org-without-partial-completion (&rest body)
`(let ((pc-mode (and (boundp 'partial-completion-mode)
'partial-completion-mode))) ; <-- quote added
(unwind-protect
(progn
(when pc-mode (funcall pc-mode -1))
,@body)
(when pc-mode (funcall pc-mode 1)))))
next reply other threads:[~2011-06-22 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 21:08 Paul Sexton [this message]
2011-06-28 16:48 ` Typo in 'org-without-partial-completion' Bastien
2011-06-30 9:12 ` Bastien
2011-06-30 19:28 ` David Maus
2011-07-02 7:34 ` David Maus
2011-07-02 9:26 ` Bastien
2011-07-02 13:50 ` David Maus
2011-07-02 14:40 ` Nick Dokos
2011-07-02 14:55 ` David Maus
2011-07-03 10:44 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20110622T230518-783@post.gmane.org \
--to=psexton@xnet.co.nz \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).