From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seweryn Kokot Subject: Re: [REQUEST] orgtbl-ctrl-c-ctrl-c-hook Date: Wed, 17 Nov 2010 09:58:19 +0000 (UTC) Message-ID: References: <2F4D54FD-C457-4372-8871-2F1A022FF082@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=46889 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIemi-0003Z4-OS for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 04:58:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIemh-0000y8-Od for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 04:58:36 -0500 Received: from lo.gmane.org ([80.91.229.12]:36982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIemh-0000xX-Dv for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 04:58:35 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PIemc-0003cs-E6 for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 10:58:30 +0100 Received: from 139.191.131.39 ([139.191.131.39]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 17 Nov 2010 10:58:30 +0100 Received: from sewkokot by 139.191.131.39 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 17 Nov 2010 10:58:30 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Carsten Dominik gmail.com> writes: > I am a bit confused by this patch. You do call the hook after C-c C-c > has done its thing. Which is OK, but this is not what the > documentation in your hook variable says. That documentation seems to > have been copied from the normal ctrl-c-ctrl-c hook, and these hooks > are used in a different way: They establish *alternative* > functionality to the normal C-c C-c actions. So if any of the hook > functions returns a non-nil value, the normal C-c C-c functionality > will *not* be executed. > > So what are your true intentions, and can you make code and > documentation macht up? Thank for you help. Indeed, the previous patch was confusing. I've done a new patch below. Is it correct now? regards, Seweryn --- h:/org-mode/lisp/org-table.el 2010-11-16 11:17:36.000000000 +0100 +++ h:/org-mode/lisp/org-table-new.el 2010-11-17 10:54:22.000000000 +0100 @@ -48,6 +48,11 @@ (defvar org-export-html-table-tag) ; defined in org-exp.el (defvar constants-unit-system) +(defvar orgtbl-ctrl-c-ctrl-c-hook nil + "Hook for functions attaching themselves to `C-c C-c'. +This can be used to add additional functionality after the table is sent +to the receiver position.") + (defcustom orgtbl-optimized (eq org-enable-table-editor 'optimized) "Non-nil means use the optimized table editor version for `orgtbl-mode'. In the optimized version, the table editor takes over all simple keys that @@ -3729,7 +3734,8 @@ (call-interactively 'org-table-recalculate) (org-table-maybe-recalculate-line)) (call-interactively 'org-table-align) - (orgtbl-send-table 'maybe)) + (orgtbl-send-table 'maybe) + (run-hooks 'orgtbl-ctrl-c-ctrl-c-hook)) ((eq action 'recalc) (save-excursion (beginning-of-line 1) Diff finished. Wed Nov 17 10:54:46 2010