From: Achim Gratz <Stromeko@Nexgo.DE>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] ob-sql.el: probably an extra paren
Date: Thu, 21 Mar 2013 18:38:24 +0100 [thread overview]
Message-ID: <kifgi3$u3f$1@ger.gmane.org> (raw)
In-Reply-To: <87fvzozx88.fsf@bzg.ath.cx>
Am 21.03.2013 14:41, schrieb Bastien:
> The test are not automatic, they are manually triggered, so we don't
> have an "automated tests framework" -- or am I misunderstanding what
> an automated test framework is?
What you probably have in mind is a continuous integration framework
that triggers the test framework.
> This I 100% agree with. I don't push commits that are known to me as
> not passing the tests :)
The cavalier attitude is not funny, smiley or not.
> It is about life being short and time being spent on testing vs
> coding.
No, this is about doing it right or doing it twice.
I have a fairly slow machine, but running "make test" or even "make
test-dirty" with all tests enabled has not consumed an appreciable
amount of my lifetime and probably never will. It has however saved me
some pushes that had incomplete commits or some "obviously safe" last
minute changes that turned out not to be or triggered some unexpected
behaviour someplace else. I have also spent a good deal of time weeding
out false positives from bisects that could have been automated if one
could assume that each commit was always passing its tests.
> If you can come up with a pre-push hook that is clever enough to
> distinguish trivial-and-safe changes against those who need to be
> tested, please submit one. A trivial-and-safe change is either:
>
> - a change against non-code files;
> - a change in docstring.
>
> I don't think this is easy to do.
It is also a waste of time and not necessary. Simply run the tests on
each commit touching lisp/ and testing/ and reject the data from the
push if any test fails. Not sure if Jason wants to put this on the
server, though.
Regards,
--
Achim.
(on the road :-)
next prev parent reply other threads:[~2013-03-21 17:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 2:54 [BUG] ob-sql.el: probably an extra paren Nick Dokos
2013-03-20 6:47 ` Bastien
2013-03-20 12:39 ` Sebastien Vauban
2013-03-20 13:47 ` Bastien
2013-03-21 8:28 ` Achim Gratz
2013-03-21 13:41 ` Bastien
2013-03-21 14:03 ` Nicolas Richard
2013-03-21 16:58 ` Yagnesh Raghava Yakkala
2013-03-21 17:31 ` Bastien
2013-03-21 18:40 ` tests with travis-ci (was: [BUG] ob-sql.el: probably an extra paren) Yagnesh Raghava Yakkala
2013-03-21 20:41 ` tests with travis-ci Bastien
2013-03-21 22:20 ` Yagnesh Raghava Yakkala
2013-03-22 7:56 ` Yann Hodique
2013-03-22 10:40 ` Yagnesh Raghava Yakkala
2013-03-31 19:07 ` Yann Hodique
2013-03-22 6:40 ` Andreas Röhler
2013-03-22 12:55 ` Nick Dokos
2013-03-22 13:07 ` Andreas Röhler
2013-03-21 17:38 ` Achim Gratz [this message]
2013-03-21 17:59 ` [BUG] ob-sql.el: probably an extra paren Bastien
2013-03-22 7:01 ` Achim Gratz
2013-03-22 7:36 ` Bastien
2013-03-22 7:59 ` Achim Gratz
2013-04-06 0:46 ` Bastien
2013-03-22 10:44 ` Yagnesh Raghava Yakkala
2013-03-21 8:37 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kifgi3$u3f$1@ger.gmane.org' \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).