From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Mark Barton <mbarton98@gmail.com>,
emacs-devel@gnu.org, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc.
Date: Wed, 27 Apr 2022 12:55:30 -0400 [thread overview]
Message-ID: <jwvilqu1n7m.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f200c9ab-d1d4-d5a8-24cf-4e1082528fe7@cs.ucla.edu> (Paul Eggert's message of "Wed, 27 Apr 2022 00:39:01 -0700")
> - (not (time-less-p (cl-subseq (nth 5 (file-attributes file)) 0 2)
> - (cl-subseq time 0 2)))))
> + (not (time-less-p (org-time-convert-to-integer
> + (nth 5 (file-attributes file)))
> + (org-time-convert-to-integer time)))))
Instead of rounding the times to whole seconds, wouldn't it make more
sense to check that the difference is larger than 1s?
Stefan
next prev parent reply other threads:[~2022-04-27 16:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:37 Mark Barton
2022-04-27 7:20 ` Po Lu
2022-04-27 7:39 ` Paul Eggert
2022-04-27 16:55 ` Stefan Monnier [this message]
2022-04-28 22:27 ` Paul Eggert
2022-04-29 14:22 ` Max Nikulin
2022-04-29 18:10 ` Paul Eggert
2022-04-30 10:56 ` Max Nikulin
2022-05-06 16:56 ` [PATCH] org-macs.el: Do not compare wall time and file modification time Max Nikulin
2022-05-11 12:28 ` Max Nikulin
2022-05-11 16:24 ` Paul Eggert
2022-05-12 16:55 ` Max Nikulin
2022-05-12 22:52 ` Paul Eggert
2022-05-13 12:28 ` Max Nikulin
2022-05-13 18:00 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvilqu1n7m.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=mbarton98@gmail.com \
--subject='Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).