emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Barton, Mark" <Mark.Barton@disney.com>
Cc: Juri Linkov <juri@linkov.net>,
	Daniel Mendler <mail@daniel-mendler.de>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: org-mode-map binds [tab]
Date: Thu, 08 Jul 2021 23:01:29 -0400	[thread overview]
Message-ID: <jwvbl7cb3cl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <B8262082-2A6C-460A-8C42-48266AD51868@disney.com> (Mark Barton's message of "Fri, 9 Jul 2021 01:39:38 +0000")

> Does outline.el need to be fixed too?
[...]
> ——snippet from outline.el
> (defvar outline-mode-cycle-map
>  (let ((map (make-sparse-keymap)))
>    (let ((tab-binding `(menu-item
>                         "" outline-cycle
>                         ;; Only takes effect if point is on a heading.
>                         :filter ,(lambda (cmd)
>                                    (when (outline-on-heading-p) cmd)))))
>      (define-key map [tab]       tab-binding)
>      (define-key map (kbd "TAB") tab-binding)
>      (define-key map (kbd "<backtab>") #'outline-cycle-buffer))
>    map)
>  "Keymap used by `outline-mode-map' and `outline-minor-mode-cycle'.")

Very much so, indeed, thanks.
I just pushed that change to `master`.


        Stefan



  reply	other threads:[~2021-07-09  3:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210626095705.11804.96621@vcs0.savannah.gnu.org>
     [not found] ` <20210626095707.B514720D0A@vcs0.savannah.gnu.org>
     [not found]   ` <jwvo8bspw03.fsf-monnier+emacs@gnu.org>
     [not found]     ` <3209a500-8654-2508-3b1a-34a73edc0053@daniel-mendler.de>
2021-06-27 15:34       ` Daniel Mendler
2021-07-01 10:17         ` Nicolas Goaziou
2021-07-09  1:39         ` Barton, Mark
2021-07-09  3:01           ` Stefan Monnier [this message]
2021-06-27 15:37       ` Bug: org-mode-map binds tab [9.4.6 (9.4.6-gab9f2a @ /home/user/.config/emacs/elpa/org-9.4.6/)] Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbl7cb3cl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=Mark.Barton@disney.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=juri@linkov.net \
    --cc=mail@daniel-mendler.de \
    --subject='Re: org-mode-map binds [tab]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).