From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6IaYJcBARmIJdAAAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 02:01:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MJv4IsBARmIWcgAA9RJhRA (envelope-from ) for ; Fri, 01 Apr 2022 02:01:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A612D4E6B for ; Fri, 1 Apr 2022 02:01:03 +0200 (CEST) Received: from localhost ([::1]:36088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na4is-0005GP-GX for larch@yhetil.org; Thu, 31 Mar 2022 20:01:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na4i1-0005FZ-4o for emacs-orgmode@gnu.org; Thu, 31 Mar 2022 20:00:09 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50460) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na4hy-0003y7-1m; Thu, 31 Mar 2022 20:00:08 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DFA41442D0A; Thu, 31 Mar 2022 20:00:03 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6171B442D0B; Thu, 31 Mar 2022 20:00:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1648771202; bh=3j7os3lzSggFrgPXO0sZ+ClygcakQU1+p0jp5qsEatw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pHCD1LcB6evq2D1R4nlesSktvOGniTDW+46q3IAHsfkaHAORplFC5AWxpw3aWIaGz 7S9uHoQxkz30lLZz8axuSDuF+BfTWmyW2Ir51tddfDZYKkrcPS0wUtuuXU4sNF7agu kTMbnQsZGVMwWw8/LYzQljuzQuK6E1GljSLHGWo8WU42/yrTtZ9+R8w0cg1dTooZ2/ E6kR0zeakZWQyIztkezN7sT+ctVckteU91lTYZYhjhouReB8itk+S89aJ7iYgdgFa6 Iu/6D7AnLztZWtiWc+ApgSjIZORROLA0nSR15lovi2ux8UOkdUg2XU3SY7UqYKQzyH ZuzTU64mn0RFg== Received: from ceviche (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 01C471205FF; Thu, 31 Mar 2022 20:00:01 -0400 (EDT) From: Stefan Monnier To: Samuel Wales Cc: emacs-orgmode@gnu.org, Bastien Subject: Re: Drop defadvice from Org Message-ID: References: <87a6drnsv6.fsf@gnu.org> <87a6dq46kd.fsf@gnu.org> Date: Thu, 31 Mar 2022 19:59:54 -0400 In-Reply-To: (Samuel Wales's message of "Thu, 31 Mar 2022 16:17:57 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648771264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CYB1xxftHy5FObTruPpfJ/CGL/5khkMx1/wPy8ejtAI=; b=Lr0ubqGWK/+Hv9U8viF0rPt62KqP1IApzznLTcNrIQZLRNuwmp9Ml8swyiqXGJWp3k7gql 0hhx09vmEEypEOspfwG0u4LBWAy90rGqKKXM9hHpflSHBjptTDK8StBAqDtQRZ2IwwtAN0 Ryi3UqrtCgN9k+dkC9BBCuCubopL2M79tZfid2PgIjEcAkO/7O3eB3frq0D0Ee52dYLXbs K6OoKDDVaRmMvczmnXy7jNsaVq6kP9PCfKRfSyaDd+TKkTA4iu+TQ9J3Bv1nye7YUreFbH 0YOp+9Kvl1Y3ZLfhiCkR2ZDnDFqkdHfcGp06JIBjX+nCfCfV9Gk+cfdAv+Khtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648771264; a=rsa-sha256; cv=none; b=F3yvCESqJsteJO4DEasYL53jSeZiNV4Zazgtcawf5XzHVyIuoyGZOxBqpsc4gArpMmAF9n T+zZ/+GIPLLIsa3XiKpIazMNgAjz6cUrrRmHfVdpjmOK8uM/5xMDi0orUAPcmIQKilN3o4 SuCzDnWI3seVZx8Ipba9FmkQqb0LZSbuCgxHPJlH5ZtoBd+pohbdmaP7vzyMk6JUphSgLk MkJawfgKWnGMduVDeAWVJ8tFjBu1c3VI5YkVrDSsYh5x5E2zS3y4ihloOChbgOjAscExIq sq1+jWNkggiJ0/4hAob3CEp4YWZ+0L/c/f/H3b16CcRQrcrb2tRq9aftE6Benw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=pHCD1LcB; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.27 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=pHCD1LcB; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A612D4E6B X-Spam-Score: -5.27 X-Migadu-Scanner: scn1.migadu.com X-TUID: Tbnyhn6qDhZW > thank you. just an idle question. is it common/desirable for built > in packages to use advice instead of hooks and such? Desirable? no. Common? kinda, yes, sadly. It's usually good to look at the existing advice as "requests for hooks". I haven't spent the energy to look at them this way, tho. IOW patches welcome. > also, merely as a plea from a user, I hope defadvice will stick around > for all that user and non-built-in and abandoned code. I definitely hope it will be gone before 2040, but it hasn't even been declared officially obsolete yet (not even in `master`), so I think you should be good at least until 2030. Stefan