From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#12702: 24.2; Orgmode Refile complains "Not bookmark format"
Date: Wed, 24 Oct 2012 13:57:34 -0400
Message-ID: <jwv3913g3h6.fsf-monnier+emacs__34676.3479793028$1351101514$gmane$org@gnu.org>
References: <50855D96.9000302@univ-brest.fr> <03liexyx5m.fsf@fencepost.gnu.org>
	<5087B1AB.3030404@univ-brest.fr>
	<jwvfw54gc2h.fsf-monnier+emacs__40840.5437753119$1351090539$gmane$org@gnu.org>
	<87d30729b0.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain; CHARSET=US-ASCII
Content-Transfer-Encoding: 7BIT
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:53295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1TR5DV-00083q-Fy
	for emacs-orgmode@gnu.org; Wed, 24 Oct 2012 13:58:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1TR5DP-0006DE-Oi
	for emacs-orgmode@gnu.org; Wed, 24 Oct 2012 13:58:09 -0400
Sender: debbugs-submit-bounces@debbugs.gnu.org
Resent-Message-ID: <handler.12702.B12702.135110157624741@debbugs.gnu.org>
In-reply-to: <87d30729b0.fsf@bzg.ath.cx>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@altern.org>
Cc: 12702@debbugs.gnu.org, Jonathan Schaeffer <jonathan.schaeffer@univ-brest.fr>

>>> The error message makes sense ... as soon as you know where the problem
>>> comes from :)
>> Also, while it's good to signal to the user that his bookmark file is
>> corrupted (and to make sure we don't overwrite it with something else),
>> I don't see why that should prevent Org's Refile from working.
> By default, org-refile and org-capture store bookmarks to the last
> refiled/captured Org headline.  (There is org-capture-bookmark in
> case users want to deactivate this for captured headlines.)
> We could skip this step in Org in case the bookmark format is
> corrupted, or have a more informative message that makes clear to 
> the user that Org tries to store a bookmark.

I don't know the details of what happens currently when the bookmark file is
corrupted but at least such an occurrence shouldn't prevent org-refile
from working (tho obviously in a degraded way).

IOW, if needed we could wrap the calls to bookmark-set in
with-demoted-errors, but maybe those errors are signaled late enough
already that while the command signals an error, it did do what it was
expected to do.


        Stefan