emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Bastien <bzg@gnu.org>
Cc: Lele Gaifax <lele@metapensiero.it>,
	emacs-orgmode@gnu.org, emacs-devel@gnu.org
Subject: Re: org-export raises stringp nil error
Date: Thu, 07 Mar 2013 20:36:33 -0500	[thread overview]
Message-ID: <jfd2va8yfy.fsf@fencepost.gnu.org> (raw)
In-Reply-To: 87zjye96ph.fsf@bzg.ath.cx

Bastien wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Assuming this is a recent regression, then if anyone from Org wants this
>> fixed in Emacs 24.3, they should investigate this very quickly and
>> suggest the _minimum_ change.
>
> The minimal fix is attached.
>
> The other attachment is the full patch I wanted to apply to merge
> Org 7.9.4 into Emacs 24.3.  The changes are all safe bugfixes.
>
> I assumed it was okay to fix bugs after the last pretest, is it so?

No, it is not ok, and I don't know why you would think it is.

"Release candidate" means "this IS the release unless something CRITICAL
occurs". I hoped my various posts to this list had made this clear. It's
also been the traditional policy of at least the more recent Emacs
releases as far as I know.

I should have been stricter in insisting that Org follow the same policy
as everybody else during pretesting, in only installing regression bug
fixes. I'm pretty sure this has not been happening, given the size and
nature of the changes that keep landing.

The reason for this policy is (obviously) to prevent inadvertently
introducing mistakes. This seems to be exactly what has bitten us in
this case, where your patch just reverts the change from

http://lists.gnu.org/archive/html/emacs-diffs/2013-02/msg00058.html

Was that fixing a regression? I doubt it.


Please apply the first patch as soon as possible.


The second includes stuff like deleting comments, declaring functions,
and changing autoload for "org-autoload". No, you may not apply this.

If there were any fixes in there for important regression bugs against
Emacs 24.2, please make a separate patch with just those items.

  reply	other threads:[~2013-03-08  1:36 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ip539io1.fsf@nautilus.nautilus>
2013-03-07 21:14 ` org-export raises stringp nil error Glenn Morris
2013-03-07 22:38   ` Bastien
2013-03-08  1:36     ` Glenn Morris [this message]
2013-03-08  6:40       ` Bastien
2013-03-08  7:16         ` Leo Liu
2013-03-08  7:37           ` Bastien
2013-03-08  7:44             ` Leo Liu
2013-03-08  7:56             ` Xue Fuqiao
2013-03-08  8:28           ` Eli Zaretskii
2013-03-08  9:15             ` joakim
2013-03-08  9:17               ` Bastien
2013-03-08  9:19               ` Bastien
2013-03-08  9:25               ` Dmitry Gutov
2013-03-08 10:23                 ` Eli Zaretskii
2013-03-08 11:18                   ` Dmitry Gutov
2013-03-08 14:06                     ` Eli Zaretskii
2013-03-08 21:00                       ` Dmitry Gutov
2013-03-08 16:34                   ` Achim Gratz
2013-03-08 19:48                     ` Eli Zaretskii
2013-03-08  9:55               ` Stephen J. Turnbull
2013-03-08 10:15               ` Eli Zaretskii
2013-03-08 11:12                 ` Dmitry Gutov
2013-03-08 14:21               ` Xue Fuqiao
2013-03-08 15:42                 ` Bastien
2013-03-08 16:29                   ` Nick Dokos
2013-03-08 16:38                     ` Jambunathan K
2013-03-08 17:09                       ` Bastien
2013-03-08 17:41                         ` Nick Dokos
2013-03-08 18:01                           ` Jambunathan K
2013-03-08 18:05                             ` Nick Dokos
2013-03-08 19:40                           ` Achim Gratz
2013-03-08 16:39                     ` Bastien
2013-03-08 22:37                     ` Xue Fuqiao
2013-03-08  7:47         ` Xue Fuqiao
2013-03-08  7:53           ` Bastien
2013-03-08  8:27           ` Stephen J. Turnbull
2013-03-08  8:58             ` Eli Zaretskii
2013-03-08  9:56               ` Stephen J. Turnbull
2013-03-08  8:30           ` Eli Zaretskii
2013-03-08  9:12             ` Bastien
2013-03-08  8:20         ` Stephen J. Turnbull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jfd2va8yfy.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=bzg@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=lele@metapensiero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).