From: Clemens <email@example.com>
To: Kyle Meyer <firstname.lastname@example.org>
Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command
Date: Wed, 22 Jul 2020 09:04:01 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
> With the built-in completion, org-set-tags-command already supports
> completing multiple tags.
Interesting, I couldn't figure out how. I tried with emacs -Q (v 26.3)
and I get only completion for the first tag. If you try to get
completion after entering the first you get an [no match] message. Maybe
I'm doing something wrong? How do you get completion after the first tag
with default completion?
> So that aim reduces to using
> completing-read-multiple because other completion libraries are more
> likely to play nicely with crm.
> At the moment that's not mentioned in the commit message (and, less
> importantly, it wasn't mentioned in the message introducing the patch),
> but in my view that aim should be the emphasis of the commit message.
> It'd be good to note the popular completion libraries that don't work
> out of the box with the current approach, and whether they do after this
As described above my initial aim was really to get completion after
entering the first tag (that is mentioned in my message introducing the
patch but it is a good idea to mention it also in the commit).
Completion frameworks automatically benefit from this if they support
> It's also probably worth mentioning why org-tags-completion-function is
> still passed as the completion function to completing-read-multiple, as
> the completion function's main purpose of completing multiple tags could
> now be fulfilled by completing-read-multiple alone. And what about the
> other spots that use org-tags-completion-function?
I haven't looked at `org-tags-completion-function` in detail will have
to check if something could be adjusted there, too. I thought usages in
other spots wouldn't be affected and should automatically work with the
new enhanced behavior. I will look into that, had you something specific
Thanks for your review and help!
next prev parent reply other threads:[~2020-07-22 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 12:49 Clemens
2020-07-19 14:26 ` Clemens
2020-07-19 14:58 ` Clemens
2020-07-19 14:59 ` Clemens
2020-07-20 3:23 ` Kyle Meyer
2020-07-20 6:03 ` Clemens
2020-07-22 4:26 ` Kyle Meyer
2020-07-22 7:04 ` Clemens [this message]
2020-07-22 7:16 ` Clemens
2020-07-22 12:37 ` Clemens
2020-07-23 4:37 ` Kyle Meyer
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH] Use completing-read-multiple for org-set-tags-command' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).