From: Max Nikulin <manikulin@gmail.com>
To: Bruno Cardoso <cardoso.bc@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add support for shortdoc link type
Date: Wed, 5 Jun 2024 22:37:00 +0700 [thread overview]
Message-ID: <fb4ebece-e08a-4296-86dc-c412890d33d5@gmail.com> (raw)
In-Reply-To: <87eda5yib3.fsf@gmail.com>
On 13/05/2024 20:04, Bruno Cardoso wrote:
> +++ b/etc/ORG-NEWS
Bruno, I am sorry, but Org-9.7 has been released and your patch can not
be cleanly applied any more. Please, rebase it and check that the new
feature is described in the proper section for changes that have not
released yet.
A couple of notes that unlikely affect real life usage.
> + (defun org-link--store-shortdoc (&optional _interactive?)
> + "Store \"shortdoc\" type link."
> + (when (eq major-mode 'shortdoc-mode)
`derived-mode-p' is more reliable in general.
> + (let* ((buffer (buffer-name))
> + (group (when (string-match "*Shortdoc \\(.*\\)\\*" buffer)
> + (match-string 1 buffer))))
> + (if (and group (assoc (intern-soft group) shortdoc--groups))
> + (org-link-store-props :type "shortdoc"
> + :link (format "shortdoc:%s" group)
> + :description nil)
> + (user-error "Unknown shortdoc group: %s" group)))))
I believed that store link functions should fail silently if no suitable
link may be offered.
next prev parent reply other threads:[~2024-06-05 15:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 3:29 [PATCH] Add support for shortdoc link type Bruno Cardoso
2024-05-01 11:00 ` Ihor Radchenko
2024-05-01 16:52 ` Bruno Cardoso
2024-05-01 17:55 ` Ihor Radchenko
2024-05-01 19:24 ` Bruno Cardoso
2024-05-02 10:41 ` Max Nikulin
2024-05-03 21:41 ` Bruno Cardoso
2024-05-04 7:38 ` Max Nikulin
2024-05-04 17:33 ` Bruno Cardoso
2024-05-05 11:01 ` Max Nikulin
2024-05-05 21:35 ` Bruno Cardoso
2024-05-06 10:55 ` Max Nikulin
2024-05-08 1:11 ` Bruno Cardoso
2024-05-08 11:20 ` Max Nikulin
2024-05-08 21:26 ` Bruno Cardoso
2024-05-10 11:09 ` Max Nikulin
2024-05-11 16:58 ` Bruno Cardoso
2024-05-13 11:14 ` Max Nikulin
2024-05-13 13:04 ` Bruno Cardoso
2024-05-16 10:58 ` Max Nikulin
2024-05-17 14:55 ` Bruno Cardoso
2024-06-04 23:59 ` Bruno Cardoso
2024-06-05 15:14 ` Ihor Radchenko
2024-06-05 21:15 ` Bastien Guerry
2024-06-05 15:37 ` Max Nikulin [this message]
2024-06-05 22:21 ` Bruno Cardoso
2024-06-06 11:53 ` Ihor Radchenko
2024-06-06 23:11 ` Bruno Cardoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4ebece-e08a-4296-86dc-c412890d33d5@gmail.com \
--to=manikulin@gmail.com \
--cc=cardoso.bc@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).