From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luke Amdor Subject: Re: Bug: org-habit and headlines with links Date: Sun, 31 Jan 2010 10:46:29 -0600 Message-ID: References: <1E17282F-E612-4269-8BD3-46935B2B9E51@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0037222701==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nbcwp-0007Sn-3t for emacs-orgmode@gnu.org; Sun, 31 Jan 2010 11:46:55 -0500 Received: from [199.232.76.173] (port=47407 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nbcwo-0007Se-HR for emacs-orgmode@gnu.org; Sun, 31 Jan 2010 11:46:54 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nbcwm-0005AP-Q1 for emacs-orgmode@gnu.org; Sun, 31 Jan 2010 11:46:54 -0500 Received: from mail-pz0-f188.google.com ([209.85.222.188]:48893) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nbcwm-0005AB-AT for emacs-orgmode@gnu.org; Sun, 31 Jan 2010 11:46:52 -0500 Received: by pzk26 with SMTP id 26so310023pzk.26 for ; Sun, 31 Jan 2010 08:46:50 -0800 (PST) In-Reply-To: <1E17282F-E612-4269-8BD3-46935B2B9E51@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --===============0037222701== Content-Type: multipart/alternative; boundary=00504502de067e96a3047e789ddf --00504502de067e96a3047e789ddf Content-Type: text/plain; charset=ISO-8859-1 That fixed it. Thanks! Luke On Thu, Jan 28, 2010 at 11:32 AM, Carsten Dominik wrote: > Hi Luke, > > thanks for the bisect, that was useful. > > Could you please try if the following patch does reliably fix this problem? > > Thanks!! > > - Carsten > > diff --git a/lisp/org-habit.el b/lisp/org-habit.el > index cf53057..deb8132 100644 > --- a/lisp/org-habit.el > +++ b/lisp/org-habit.el > @@ -305,7 +305,7 @@ current time." > (defun org-habit-insert-consistency-graphs (&optional line) > "Insert consistency graph for any habitual tasks." > (let ((inhibit-read-only t) l c > - (buffer-invisibility-spec nil) > + (buffer-invisibility-spec '(org-link)) > (moment (time-subtract (current-time) > (list 0 (* 3600 org-extend-today-until) 0)))) > (save-excursion > > > On Jan 17, 2010, at 4:45 PM, Luke Amdor wrote: > > When I have a headline with a link on it and I have that headline's habit >> property set to true, org-habit will barf all over my link when presenting >> the agenda. This will only happen when org-habit-graph-column is set >> something shorter than the full raw text of the link (which is about all of >> them). >> >> I ran git bisect on org-mode and found the bad commit to be: >> >> commit 2f5f6e401f187c2db8131cdbc4355b688ce4c55a >> Author: Carsten Dominik >> Date: Mon Jan 4 09:58:53 2010 +0100 >> >> Turn off invisibility while constructing habit graphs >> >> Bernt Hansen reported strange things happening to the display when >> graph tasks are hidden while updating a task in the agenda. >> >> Here's my bisect log: >> >> # bad: [0e370d498b34469a025cdce864fd5c5987bf8050] Fix typo >> # good: [a7fb89e9edf59f50294199046e570b4b11bb13b1] Merge branch 'master' >> of git+ssh://repo.or.cz/srv/git/org-mode >> git bisect start 'origin/master' 'HEAD' >> # good: [21ad7f0bef20addfe15fbe3e95d65e6c810d68f1] Fix typo >> git bisect good 21ad7f0bef20addfe15fbe3e95d65e6c810d68f1 >> # good: [0b5d9bf1c62454523b275dd6a6b95bf881580eb1] Merge branch >> 'org-ctags' >> git bisect good 0b5d9bf1c62454523b275dd6a6b95bf881580eb1 >> # bad: [588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9] org-exp-generic.el: Fix >> bug with closing bodies >> git bisect bad 588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9 >> # bad: [32441cd15150f541d3ba50633cfb9fffc8d3d11a] Fix agenda link opening >> bug >> git bisect bad 32441cd15150f541d3ba50633cfb9fffc8d3d11a >> # bad: [ddcb2be1c8920fabfbca3777cc774ed1ac653a6e] Work-around for >> formatting bug with email subject line from wanderlust >> git bisect bad ddcb2be1c8920fabfbca3777cc774ed1ac653a6e >> # good: [c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710] Make C-c r C customize >> remember templates >> git bisect good c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710 >> # good: [f266ee62bb8282cc883adea9f26362b2d3b1ab7d] Fix typo >> git bisect good f266ee62bb8282cc883adea9f26362b2d3b1ab7d >> # bad: [2f5f6e401f187c2db8131cdbc4355b688ce4c55a] Turn off invisibility >> while constructing habit graphs >> git bisect bad 2f5f6e401f187c2db8131cdbc4355b688ce4c55a >> >> Luke >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >> > > - Carsten > > > > --00504502de067e96a3047e789ddf Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable That fixed it. Thanks!

Luke


On Thu, Jan 28, 2010 at 11:32 AM, Carste= n Dominik <carsten.dominik@gmail.com> wrote:
Hi Luke,

thanks for the bisect, that was useful.

Could you please try if the following patch does reliably fix this problem?=

Thanks!!

- Carsten

diff --git a/lisp/org-habit.el b/lisp/org-habit.el
index cf53057..deb8132 100644
--- a/lisp/org-habit.el
+++ b/lisp/org-habit.el
@@ -305,7 +305,7 @@ current time."
=A0(defun org-habit-insert-consistency-graphs (&optional line)
=A0 "Insert consistency graph for any habitual tasks."
=A0 (let ((inhibit-read-only t) l c
- =A0 =A0 =A0 (buffer-invisibility-spec nil)
+ =A0 =A0 =A0 (buffer-invisibility-spec '(org-link))
=A0 =A0 =A0 =A0(moment (time-subtract (current-time)
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (list 0 (* 360= 0 org-extend-today-until) 0))))
=A0 =A0 (save-excursion


On Jan 17, 2010, at 4:45 PM, Luke Amdor wrote:

When I have a headline with a link on it and I have that headline's hab= it property set to true, org-habit will barf all over my link when presenti= ng the agenda. This will only happen when org-habit-graph-column is set som= ething shorter than the full raw text of the link (which is about all of th= em).

I ran git bisect on org-mode and found the bad commit to be:

commit 2f5f6e401f187c2db8131cdbc4355b688ce4c55a
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date: =A0 Mon Jan 4 09:58:53 2010 +0100

=A0 =A0Turn off invisibility while constructing habit graphs

=A0 =A0Bernt Hansen reported strange things happening to the display when<= br> =A0 =A0graph tasks are hidden while updating a task in the agenda.

Here's my bisect log:

# bad: [0e370d498b34469a025cdce864fd5c5987bf8050] Fix typo
# good: [a7fb89e9edf59f50294199046e570b4b11bb13b1] Merge branch 'master= ' of git+ssh://repo.or.cz/srv/git/org-mode
git bisect start 'origin/master' 'HEAD'
# good: [21ad7f0bef20addfe15fbe3e95d65e6c810d68f1] Fix typo
git bisect good 21ad7f0bef20addfe15fbe3e95d65e6c810d68f1
# good: [0b5d9bf1c62454523b275dd6a6b95bf881580eb1] Merge branch 'org-ct= ags'
git bisect good 0b5d9bf1c62454523b275dd6a6b95bf881580eb1
# bad: [588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9] org-exp-generic.el: Fix b= ug with closing bodies
git bisect bad 588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9
# bad: [32441cd15150f541d3ba50633cfb9fffc8d3d11a] Fix agenda link opening b= ug
git bisect bad 32441cd15150f541d3ba50633cfb9fffc8d3d11a
# bad: [ddcb2be1c8920fabfbca3777cc774ed1ac653a6e] Work-around for formattin= g bug with email subject line from wanderlust
git bisect bad ddcb2be1c8920fabfbca3777cc774ed1ac653a6e
# good: [c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710] Make C-c r C customize r= emember templates
git bisect good c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710
# good: [f266ee62bb8282cc883adea9f26362b2d3b1ab7d] Fix typo
git bisect good f266ee62bb8282cc883adea9f26362b2d3b1ab7d
# bad: [2f5f6e401f187c2db8131cdbc4355b688ce4c55a] Turn off invisibility whi= le constructing habit graphs
git bisect bad 2f5f6e401f187c2db8131cdbc4355b688ce4c55a

Luke
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gn= u.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten




--00504502de067e96a3047e789ddf-- --===============0037222701== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0037222701==--