emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Patch] Bug: org-indent-region doesn't restore cursor position when org-src-tab-acts-natively is t [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.3/lisp/org/)]
Date: Sun, 16 May 2021 17:28:50 +0000	[thread overview]
Message-ID: <f96ca466-a769-4438-4da6-767bfa989b08@posteo.eu> (raw)
In-Reply-To: <87cztqswrb.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi Bastien,

Bastien writes:
> Sorry it took so long to apply this patch, this is now done in maint.
No problem, thank you for getting back on this.

I think something went wrong though. I've attached as a new patch a
part of the previous one that wasn't applied. Without it, some
write-back buffers are never killed.

Regards,

-- 
Sébastien Miquel


[-- Attachment #2: 0001-org-src.el-org-edit-src-exit-Fix-write-back-buf-not-.patch --]
[-- Type: text/x-patch, Size: 1166 bytes --]

From f293a9d5808c413ce785646ebf5f480df3a00a2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?= <sebastien.miquel@posteo.eu>
Date: Sun, 16 May 2021 19:13:53 +0200
Subject: [PATCH] org-src.el (org-edit-src-exit): Fix write-back-buf not
 getting killed

* lisp/org.el (org-edit-src-exit): Fix write-back-buf not getting
killed
---
 lisp/org-src.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-src.el b/lisp/org-src.el
index df3c76e13..5604e6568 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -1255,8 +1255,8 @@ Throw an error if there is no such buffer."
 	       (narrow-to-region beg end)
 	       (replace-buffer-contents write-back-buf)
 	       (goto-char (point-max))))
-	 (when (and expecting-bol (not (bolp))) (insert "\n")))
-       (when write-back-buf (kill-buffer write-back-buf))))
+	 (when (and expecting-bol (not (bolp))) (insert "\n")))))
+    (when write-back-buf (kill-buffer write-back-buf))
     ;; If we are to return to source buffer, put point at an
     ;; appropriate location.  In particular, if block is hidden, move
     ;; to the beginning of the block opening line.
-- 
2.31.1


  reply	other threads:[~2021-05-16 17:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 10:22 Sébastien Miquel
2020-02-03 18:47 ` Bastien
2020-02-04  6:47   ` Sébastien Miquel
2020-02-04 16:07     ` Bastien
2020-02-09 15:26       ` Sébastien Miquel
2020-02-10  6:25         ` Bastien
2020-02-29 20:24           ` Sébastien Miquel
2020-09-04 10:31             ` Bastien
2020-10-04 21:08               ` [Patch] " Sébastien Miquel
2020-10-23 21:06                 ` Sébastien Miquel
2021-05-16 12:12                   ` Bastien
2021-05-16 17:28                     ` Sébastien Miquel [this message]
2021-05-16 19:53                       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f96ca466-a769-4438-4da6-767bfa989b08@posteo.eu \
    --to=sebastien.miquel@posteo.eu \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [Patch] Bug: org-indent-region doesn'\''t restore cursor position when org-src-tab-acts-natively is t [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.3/lisp/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).