From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Panteleev Subject: Re: [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments Date: Sun, 18 Mar 2018 22:43:43 +0000 Message-ID: References: <20180307225847.24068-1-git@thecybershadow.net> <20180307225847.24068-2-git@thecybershadow.net> <87muzcans9.fsf@nicolasgoaziou.fr> <9107300b-c95d-ad16-ca03-088d173c90d9@gmail.com> <87605yn4x3.fsf@nicolasgoaziou.fr> <8258182a-5d7e-d8c9-96c2-1a76dd9e143c@gmail.com> <87fu52ln2g.fsf@nicolasgoaziou.fr> <87a7v5c99c.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exh1r-0006DQ-5w for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 18:43:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exh1o-0007ZL-3E for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 18:43:51 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exh1n-0007YE-S3 for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 18:43:48 -0400 Received: by mail-wm0-x243.google.com with SMTP id n3so12225114wmd.1 for ; Sun, 18 Mar 2018 15:43:47 -0700 (PDT) In-Reply-To: <87a7v5c99c.fsf@nicolasgoaziou.fr> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org, Vladimir Panteleev Hi, On 2018-03-18 22:24, Nicolas Goaziou wrote: > We're clearly mis-communicating. I know the difference between a symbol > and a string, and how `read' operates. I think what puzzles me is some > design choices made in `org-sbe', and the fact that the second note of > its docstring is clear as mud. Ah! Well, thanks for the clarification, and apologies for the confusion. > I consider it to be a bug if you need to write $"string" instead of > "string" in any `org-sbe' call. We should not test such a mis-feature, > which should be removed. Agreed completely, but, wouldn't this be a breaking change? So far I've tried to avoid breaking any meaningful existing uses of org-sbe. > Let me insist on this. $"string" (or $ "string") is very wrong. Please > do not write your tests on top of this. IIUC, `org-sbe' is about passing > table fields into source blocks. Let's test that instead, with a table, > and a source block. I don't mind superfluous coverage. > > It is just a matter of tests. Your changes sound good. So, would you > mind adjusting your tests so we can move forward? No problem. To clarify, would you prefer tests which still use $-prefixing, but with a table cell reference to get the value in the cell (i.e. $$2), or tests which do not use $-prefixing in order to interpret the string in the table cell as a reference to another block in the org-mode document? -- Best regards, Vladimir