From: Paul Griepentrog <pgriepen@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fix org-goto when no file exists for a buffer
Date: Wed, 9 Dec 2009 15:13:45 -0800 [thread overview]
Message-ID: <f483c1730912091513k392b871dxc37e723794e7fef3@mail.gmail.com> (raw)
Thanks for Org-mode!
Every once in a while I use org-mode in a buffer that is not
associated with a file... and then org-goto gets confused. To repeat:
BUFFER-NO-FILE
---------------
* One
- a
* Two
- b
---------------
M-x org-mode
C-c C-j
org-get-refile-targets: Wrong type argument: stringp, nil
;; Environment & Settings
Org-mode version 6.33trans
"GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
of 2009-07-29 on SOFT-MJASON"
;; Org keybinding preferences
(setq
org-M-RET-may-split-line nil
org-completion-use-ido t
org-fast-tag-selection-single-key 'expert
org-goto-interface 'outline-path-completion
org-outline-path-complete-in-steps nil ; use iDo when jumping
org-refile-targets '((nil :maxlevel . 2))
; Search current buffer, upto depth=2
org-special-ctrl-a/e t
org-special-ctrl-k t)
This patch fixes it:
--- c:/cygwin/home/pgriepentrog/rc.git/emacs/download/org-mode.git/lisp/org.el 2009-12-09
13:45:42.031250000 -0800
+++ c:/cygwin/home/pgriepentrog/Local/share/emacs/site-lisp/org.el 2009-12-09
14:17:57.203125000 -0800
@@ -8986,9 +8986,9 @@
(with-current-buffer
(if (bufferp f) f (org-get-agenda-file-buffer f))
(if (bufferp f) (setq f (buffer-file-name (buffer-base-buffer f))))
- (setq f (expand-file-name f))
(if (eq org-refile-use-outline-path 'file)
- (push (list (file-name-nondirectory f) f nil nil) targets))
+ (progn (setq f (expand-file-name f))
+ (push (list (file-name-nondirectory f) f nil
nil) targets)))
(save-excursion
(save-restriction
(widen)
next reply other threads:[~2009-12-09 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 23:13 Paul Griepentrog [this message]
2009-12-10 8:15 ` [PATCH] Fix org-goto when no file exists for a buffer Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f483c1730912091513k392b871dxc37e723794e7fef3@mail.gmail.com \
--to=pgriepen@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).