From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reimar Finken Subject: Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes Date: Wed, 30 Sep 2009 17:56:38 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt1iF-0002Mm-0M for emacs-orgmode@gnu.org; Wed, 30 Sep 2009 12:07:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt1iA-0002Ly-BJ for emacs-orgmode@gnu.org; Wed, 30 Sep 2009 12:07:30 -0400 Received: from [199.232.76.173] (port=54347 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt1i9-0002Lv-UY for emacs-orgmode@gnu.org; Wed, 30 Sep 2009 12:07:25 -0400 Received: from endor.theo2.physik.uni-stuttgart.de ([129.69.228.125]:38124) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt1i8-0003hY-S0 for emacs-orgmode@gnu.org; Wed, 30 Sep 2009 12:07:25 -0400 Received: from rhea.theo2.physik.uni-stuttgart.de (rhea.theo2.physik.uni-stuttgart.de [129.69.125.131]) by endor.theo2.physik.uni-stuttgart.de (Postfix) with ESMTP id 2826130000887 for ; Wed, 30 Sep 2009 18:07:23 +0200 (CEST) Received: from larissa.theo2.physik.uni-stuttgart.de.theo2.physik.uni-stuttgart.de (larissa.theo2.physik.uni-stuttgart.de [129.69.125.198]) by rhea.theo2.physik.uni-stuttgart.de (Postfix) with ESMTP id D23BFE8250 for ; Wed, 30 Sep 2009 18:07:22 +0200 (CEST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org [Sorry for the double post, I was too quick with my C-c C-c] Clocking in on any task (C-c C-x C-i) and cancelling afterwards (C-c C-x C-x) results in the following backtrace: ,---- | Debugger entered--Lisp error: (wrong-type-argument markerp org-clock-marker) | move-marker(org-clock-marker nil) | org-clock-cancel() | call-interactively(org-clock-cancel nil nil) `---- Culprit are two erroneous quotes in front of org-clock-marker in org-clock-el. The patch (output of git diff -u on a clean checkout) fixes the problem: diff --git a/lisp/org-clock.el b/lisp/org-clock.el index e279898..91a4bcb 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -818,8 +818,8 @@ If there is no running clock, throw an error, unless FAIL-QUIETLY is set." (set-buffer (marker-buffer org-clock-marker)) (goto-char org-clock-marker) (delete-region (1- (point-at-bol)) (point-at-eol))) - (move-marker 'org-clock-marker nil) - (move-marker 'org-clock-hd-marker nil) + (move-marker org-clock-marker nil) + (move-marker org-clock-hd-marker nil) (setq global-mode-string (delq 'org-mode-line-string global-mode-string)) (force-mode-line-update) Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4) of 2009-07-30 on build21 Package: Org-mode version 6.31 (release_6.31) current state: ============== (setq org-after-todo-state-change-hook '(org-clock-out-if-current) org-export-preprocess-hook '(org-export-blocks-preprocess) org-tab-first-hook '(org-hide-block-toggle-maybe) org-src-mode-hook '(org-src-mode-configure-edit-buffer) org-confirm-shell-link-function 'yes-or-no-p org-agenda-before-write-hook '(org-agenda-add-entry-text) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-mode-hook '((lambda nil (org-add-hook (quote change-major-mode-hook) (quote org-show-block-all) (quote append) (quote local)) ) ) org-confirm-elisp-link-function 'yes-or-no-p org-occur-hook '(org-first-headline-recenter) )