From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manish Subject: Re: [PATCH 0/2] Teach org-version to include git version information Date: Wed, 19 Aug 2009 17:49:02 +0530 Message-ID: References: <1250616163-11733-1-git-send-email-bernt@norang.ca> <668A7B70-E1E0-485E-9537-64C5A039DEF4@gmail.com> <87bpmdaqff.fsf@gollum.intra.norang.ca> <4D2E35AC-DBAB-499C-946A-2BB86D6C2AA3@gmail.com> <87tz04yrk0.fsf@gollum.intra.norang.ca> <87prasypiv.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mdk8X-0002YB-Ut for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:19:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mdk8S-0002Oz-8B for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:19:28 -0400 Received: from [199.232.76.173] (port=36971 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mdk8S-0002Og-1z for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:19:24 -0400 Received: from mail-yw0-f190.google.com ([209.85.211.190]:60253) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mdk8Q-0008IP-M3 for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 08:19:23 -0400 Received: by ywh28 with SMTP id 28so6192631ywh.27 for ; Wed, 19 Aug 2009 05:19:22 -0700 (PDT) In-Reply-To: <87prasypiv.fsf@gollum.intra.norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org, Carsten Dominik On Wed, Aug 19, 2009 at 5:38 PM, Bernt Hansen wrote: > Manish writes: > >> On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: >>> Does it crash and cause an error or report the old org version as before? >> >> It just reports the version as before; no crashing or error of any sort. > > Okay that's good. I don't have Emacs on windows here. If you have time > to step through the org-version function in debug and figure out where > it fails we might be able to get it working on windows too. I'll find out how to do this and let you know the results. > > My guess is that determining the location of the .git directory fails so > it acts just like it's not running from a git repository. > > What do you get when evaluating the following form? > > (file-name-directory (locate-library "org")) > > I need to move up one directory from what that returns to see if the > .git directory exists and I append '../' to the path to move up on *nix > systems. That probably doesn't work for windows. Maybe there's a > better way to strip off the last directory from the path that > file-name-directory returns. It returns "d:/home/zms/elisp/org-mode.git/lisp/" cd'ing into "d:/home/zms/elisp/org-mode.git/lisp/.." works in Cygwin but fails in Windows shell due to front slahes. -- Manish